containerd/log
Sebastiaan van Stijn 19d6c37a3f
Revert "log: define G() as a function instead of a variable"
This reverts commit 778ac302b2.

(slightly modified, due to changes that were merged after that).

The reverted commit had two elements;

- Make `G` an actual function to improve the documentation
- Prevent `G` from being overwritten externally

From the commit that's reverted:

> The `G` variable is exported, and not expected to be overwritten
> externally. Defining it as a function also documents it as a function
> on https://pkg.go.dev, instead of a variable; https://pkg.go.dev/github.com/containerd/containerd@v1.6.22/log#pkg-variables

While it's unclear if the ability to replace the implementation was
_intentional_, it's this part that some external consumers were (ab)using.

We should look into that part in a follow-up, and design for this, for
example by providing a utility to replace the logger, and properly document
that.

In the meantime, let's revert the change.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-08-30 21:46:21 +02:00
..
logtest log/logtest: add testcase as debug field 2023-01-29 13:09:55 +08:00
context_test.go log: make Fields type a generic map[string]any 2023-07-30 22:55:37 +02:00
context.go Revert "log: define G() as a function instead of a variable" 2023-08-30 21:46:21 +02:00