d4fb0709c9
For missing required parameters adds error return before attempting any actions to `ctr images` commands. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
52 lines
1.3 KiB
Go
52 lines
1.3 KiB
Go
package images
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/containerd/containerd/cmd/ctr/commands"
|
|
"github.com/containerd/containerd/cmd/ctr/commands/content"
|
|
"github.com/containerd/containerd/log"
|
|
"github.com/urfave/cli"
|
|
)
|
|
|
|
var pullCommand = cli.Command{
|
|
Name: "pull",
|
|
Usage: "pull an image from a remote",
|
|
ArgsUsage: "[flags] <ref>",
|
|
Description: `Fetch and prepare an image for use in containerd.
|
|
|
|
After pulling an image, it should be ready to use the same reference in a run
|
|
command. As part of this process, we do the following:
|
|
|
|
1. Fetch all resources into containerd.
|
|
2. Prepare the snapshot filesystem with the pulled resources.
|
|
3. Register metadata for the image.
|
|
`,
|
|
Flags: append(commands.RegistryFlags, append(commands.SnapshotterFlags, commands.LabelFlag)...),
|
|
Action: func(context *cli.Context) error {
|
|
var (
|
|
ref = context.Args().First()
|
|
)
|
|
if ref == "" {
|
|
return fmt.Errorf("please provide an image reference to pull")
|
|
}
|
|
ctx, cancel := commands.AppContext(context)
|
|
defer cancel()
|
|
|
|
img, err := content.Fetch(ref, context)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
log.G(ctx).WithField("image", ref).Debug("unpacking")
|
|
|
|
// TODO: Show unpack status
|
|
fmt.Printf("unpacking %s...\n", img.Target().Digest)
|
|
err = img.Unpack(ctx, context.String("snapshotter"))
|
|
if err == nil {
|
|
fmt.Println("done")
|
|
}
|
|
return err
|
|
},
|
|
}
|