 b5e1b8f619
			
		
	
	b5e1b8f619
	
	
	
		
			
			A majority of the tests in /pkg/cri are testing/validating multiple things per test (generally spec or options validations). This flow lends itself well to using *testing.T's Run method to run each thing as a subtest so `go test` output can actually display which subtest failed/passed. Some of the tests in the packages in pkg/cri already did this, but a bunch simply logged what sub-testcase was currently running without invoking t.Run. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
		
			
				
	
	
		
			118 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			118 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
|    Copyright The containerd Authors.
 | |
| 
 | |
|    Licensed under the Apache License, Version 2.0 (the "License");
 | |
|    you may not use this file except in compliance with the License.
 | |
|    You may obtain a copy of the License at
 | |
| 
 | |
|        http://www.apache.org/licenses/LICENSE-2.0
 | |
| 
 | |
|    Unless required by applicable law or agreed to in writing, software
 | |
|    distributed under the License is distributed on an "AS IS" BASIS,
 | |
|    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
|    See the License for the specific language governing permissions and
 | |
|    limitations under the License.
 | |
| */
 | |
| 
 | |
| package server
 | |
| 
 | |
| import (
 | |
| 	"testing"
 | |
| 	"time"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| 	runtime "k8s.io/cri-api/pkg/apis/runtime/v1"
 | |
| 
 | |
| 	sandboxstore "github.com/containerd/containerd/pkg/cri/store/sandbox"
 | |
| )
 | |
| 
 | |
| func TestPodSandboxStatus(t *testing.T) {
 | |
| 	const (
 | |
| 		id = "test-id"
 | |
| 		ip = "10.10.10.10"
 | |
| 	)
 | |
| 	additionalIPs := []string{"8.8.8.8", "2001:db8:85a3::8a2e:370:7334"}
 | |
| 	createdAt := time.Now()
 | |
| 	config := &runtime.PodSandboxConfig{
 | |
| 		Metadata: &runtime.PodSandboxMetadata{
 | |
| 			Name:      "test-name",
 | |
| 			Uid:       "test-uid",
 | |
| 			Namespace: "test-ns",
 | |
| 			Attempt:   1,
 | |
| 		},
 | |
| 		Linux: &runtime.LinuxPodSandboxConfig{
 | |
| 			SecurityContext: &runtime.LinuxSandboxSecurityContext{
 | |
| 				NamespaceOptions: &runtime.NamespaceOption{
 | |
| 					Network: runtime.NamespaceMode_NODE,
 | |
| 					Pid:     runtime.NamespaceMode_CONTAINER,
 | |
| 					Ipc:     runtime.NamespaceMode_POD,
 | |
| 				},
 | |
| 			},
 | |
| 		},
 | |
| 		Labels:      map[string]string{"a": "b"},
 | |
| 		Annotations: map[string]string{"c": "d"},
 | |
| 	}
 | |
| 	metadata := sandboxstore.Metadata{
 | |
| 		ID:             id,
 | |
| 		Name:           "test-name",
 | |
| 		Config:         config,
 | |
| 		RuntimeHandler: "test-runtime-handler",
 | |
| 	}
 | |
| 
 | |
| 	expected := &runtime.PodSandboxStatus{
 | |
| 		Id:        id,
 | |
| 		Metadata:  config.GetMetadata(),
 | |
| 		CreatedAt: createdAt.UnixNano(),
 | |
| 		Network: &runtime.PodSandboxNetworkStatus{
 | |
| 			Ip: ip,
 | |
| 			AdditionalIps: []*runtime.PodIP{
 | |
| 				{
 | |
| 					Ip: additionalIPs[0],
 | |
| 				},
 | |
| 				{
 | |
| 					Ip: additionalIPs[1],
 | |
| 				},
 | |
| 			},
 | |
| 		},
 | |
| 		Linux: &runtime.LinuxPodSandboxStatus{
 | |
| 			Namespaces: &runtime.Namespace{
 | |
| 				Options: &runtime.NamespaceOption{
 | |
| 					Network: runtime.NamespaceMode_NODE,
 | |
| 					Pid:     runtime.NamespaceMode_CONTAINER,
 | |
| 					Ipc:     runtime.NamespaceMode_POD,
 | |
| 				},
 | |
| 			},
 | |
| 		},
 | |
| 		Labels:         config.GetLabels(),
 | |
| 		Annotations:    config.GetAnnotations(),
 | |
| 		RuntimeHandler: "test-runtime-handler",
 | |
| 	}
 | |
| 	for desc, test := range map[string]struct {
 | |
| 		state         sandboxstore.State
 | |
| 		expectedState runtime.PodSandboxState
 | |
| 	}{
 | |
| 		"sandbox state ready": {
 | |
| 			state:         sandboxstore.StateReady,
 | |
| 			expectedState: runtime.PodSandboxState_SANDBOX_READY,
 | |
| 		},
 | |
| 		"sandbox state not ready": {
 | |
| 			state:         sandboxstore.StateNotReady,
 | |
| 			expectedState: runtime.PodSandboxState_SANDBOX_NOTREADY,
 | |
| 		},
 | |
| 		"sandbox state unknown": {
 | |
| 			state:         sandboxstore.StateUnknown,
 | |
| 			expectedState: runtime.PodSandboxState_SANDBOX_NOTREADY,
 | |
| 		},
 | |
| 	} {
 | |
| 		t.Run(desc, func(t *testing.T) {
 | |
| 			status := sandboxstore.Status{
 | |
| 				CreatedAt: createdAt,
 | |
| 				State:     test.state,
 | |
| 			}
 | |
| 			expected.State = test.expectedState
 | |
| 			got := toCRISandboxStatus(metadata, status, ip, additionalIPs)
 | |
| 			assert.Equal(t, expected, got)
 | |
| 		})
 | |
| 	}
 | |
| }
 |