github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

kubetestgen: improve errors handling

Browse Source 
- don't proceed when a file creation has been failed
- handle a possible error from WriteString()
This commit is contained in:
Slava Semushin 2020-01-06 15:21:54 +00:00 committed by GitHub
parent e7eed1ad2c
commit 02885845ff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/conformance/kubetestgen/kubetestgen.go
View File

@ -131,6 +131,7 @@ func printYAML(fileName string, areaO Area) {
f, err := os.Create(fileName + ".yaml") f, err := os.Create(fileName + ".yaml")
if err != nil { if err != nil {
fmt.Printf("ERROR: %s\n", err.Error()) fmt.Printf("ERROR: %s\n", err.Error())
os.Exit(1)
} }
defer f.Close() defer f.Close()
y, err := yaml.Marshal(areaO) y, err := yaml.Marshal(areaO)
@ -139,7 +140,11 @@ func printYAML(fileName string, areaO Area) {
os.Exit(1) os.Exit(1)
} }
f.WriteString(string(y)) _, err = f.WriteString(string(y))
if err != nil {
fmt.Printf("ERROR: %s\n", err.Error())
os.Exit(1)
}
} }
func countFields(suites []Suite) { func countFields(suites []Suite) {