Apply suggestions from code review
Co-authored-by: Mahamed Ali <cy@borg.dev>
This commit is contained in:
		@@ -330,10 +330,10 @@ function find-tar() {
 | 
				
			|||||||
function find-release-tars() {
 | 
					function find-release-tars() {
 | 
				
			||||||
  # Use first item in KUBE_BUILD_PLATFORMS as server platform
 | 
					  # Use first item in KUBE_BUILD_PLATFORMS as server platform
 | 
				
			||||||
  KUBE_BUILD_PLATFORMS=${KUBE_BUILD_PLATFORMS:-"linux/amd64"}
 | 
					  KUBE_BUILD_PLATFORMS=${KUBE_BUILD_PLATFORMS:-"linux/amd64"}
 | 
				
			||||||
  SERVER_PLATFORM=$(cut -d' ' -f1 <<< $KUBE_BUILD_PLATFORMS)
 | 
					  SERVER_PLATFORM=$(cut -d' ' -f1 <<< "${KUBE_BUILD_PLATFORMS}")
 | 
				
			||||||
  OS=$(cut -d'/' -f1 <<< $SERVER_PLATFORM)
 | 
					  OS=$(cut -d'/' -f1 <<< "${SERVER_PLATFORM}")
 | 
				
			||||||
  ARCH=$(cut -d'/' -f2 <<< $SERVER_PLATFORM)
 | 
					  ARCH=$(cut -d'/' -f2 <<< "${SERVER_PLATFORM}")
 | 
				
			||||||
  SERVER_BINARY_TAR=$(find-tar kubernetes-server-${OS}-${ARCH}.tar.gz)
 | 
					  SERVER_BINARY_TAR=$(find-tar kubernetes-server-"${OS}"-"${ARCH}".tar.gz)
 | 
				
			||||||
  if [[ -z "${SERVER_BINARY_TAR}" ]]; then
 | 
					  if [[ -z "${SERVER_BINARY_TAR}" ]]; then
 | 
				
			||||||
	  exit 1
 | 
						  exit 1
 | 
				
			||||||
  fi
 | 
					  fi
 | 
				
			||||||
@@ -341,7 +341,7 @@ function find-release-tars() {
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
  local find_result
 | 
					  local find_result
 | 
				
			||||||
  if [[ "${NUM_WINDOWS_NODES}" -gt "0" ]]; then
 | 
					  if [[ "${NUM_WINDOWS_NODES}" -gt "0" ]]; then
 | 
				
			||||||
    if NODE_BINARY_TAR=$(find-tar kubernetes-node-windows-${ARCH}.tar.gz); then
 | 
					    if NODE_BINARY_TAR=$(find-tar kubernetes-node-windows-"${ARCH}".tar.gz); then
 | 
				
			||||||
      find_result=0
 | 
					      find_result=0
 | 
				
			||||||
    else
 | 
					    else
 | 
				
			||||||
      find_result=1
 | 
					      find_result=1
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user