github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #122931 from danwinship/ip-validation-cleanup

Browse Source 
consistently use IsValidIP for IP validation
This commit is contained in:
Kubernetes Prow Robot
2024-02-06 15:58:15 -08:00
committed by GitHub
parent eb5b9b0b6d 1d59d6b6c6
commit 052bce26f4
4 changed files with 183 additions and 173 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/apis/networking/validation/validation.go
View File

@@ -354,9 +354,7 @@ func ValidateIngressLoadBalancerStatus(status *networking.IngressLoadBalancerSta
for i, ingress := range status.Ingress {
idxPath := fldPath.Child("ingress").Index(i)
if len(ingress.IP) > 0 {
if isIP := (netutils.ParseIPSloppy(ingress.IP) != nil); !isIP {
allErrs = append(allErrs, field.Invalid(idxPath.Child("ip"), ingress.IP, "must be a valid IP address"))
}
allErrs = append(allErrs, validation.IsValidIP(idxPath.Child("ip"), ingress.IP)...)
}
if len(ingress.Hostname) > 0 {
for _, msg := range validation.IsDNS1123Subdomain(ingress.Hostname) {