From 066dbb72062d00f17c42e0bcb805794530e9542c Mon Sep 17 00:00:00 2001 From: Alexander Campbell Date: Thu, 25 May 2017 12:30:19 -0700 Subject: [PATCH] cmd: make createDeployment a private function --- pkg/kubectl/cmd/create_deployment.go | 5 ++--- pkg/kubectl/cmd/create_deployment_test.go | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/kubectl/cmd/create_deployment.go b/pkg/kubectl/cmd/create_deployment.go index b7033d41f0e..b8fe848218c 100644 --- a/pkg/kubectl/cmd/create_deployment.go +++ b/pkg/kubectl/cmd/create_deployment.go @@ -49,7 +49,7 @@ func NewCmdCreateDeployment(f cmdutil.Factory, cmdOut, cmdErr io.Writer) *cobra. Long: deploymentLong, Example: deploymentExample, Run: func(cmd *cobra.Command, args []string) { - err := CreateDeployment(f, cmdOut, cmdErr, cmd, args) + err := createDeployment(f, cmdOut, cmdErr, cmd, args) cmdutil.CheckErr(err) }, } @@ -62,8 +62,7 @@ func NewCmdCreateDeployment(f cmdutil.Factory, cmdOut, cmdErr io.Writer) *cobra. return cmd } -// CreateDeployment implements the behavior to run the create deployment command -func CreateDeployment(f cmdutil.Factory, cmdOut, cmdErr io.Writer, cmd *cobra.Command, args []string) error { +func createDeployment(f cmdutil.Factory, cmdOut, cmdErr io.Writer, cmd *cobra.Command, args []string) error { name, err := NameFromCommandArgs(cmd, args) if err != nil { return err diff --git a/pkg/kubectl/cmd/create_deployment_test.go b/pkg/kubectl/cmd/create_deployment_test.go index 9dd6720b785..33fefd6a839 100644 --- a/pkg/kubectl/cmd/create_deployment_test.go +++ b/pkg/kubectl/cmd/create_deployment_test.go @@ -80,6 +80,6 @@ func TestCreateDeploymentNoImage(t *testing.T) { cmd := NewCmdCreateDeployment(f, buf, buf) cmd.Flags().Set("dry-run", "true") cmd.Flags().Set("output", "name") - err := CreateDeployment(f, buf, buf, cmd, []string{depName}) + err := createDeployment(f, buf, buf, cmd, []string{depName}) assert.Error(t, err, "at least one image must be specified") }