github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove ImagePull metric in Kubelet.

Browse Source 
There is an equivalent metric from our Docker metrics and this one is
harder to maintain with the RuntimeHooks.
This commit is contained in:
Victor Marmol
2015-04-29 13:58:29 -07:00
parent 2a01a2c7e9
commit 090d0c95fa
3 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/kubelet/runtime_hooks.go
View File

@@ -49,15 +49,15 @@ func (kr *kubeletRuntimeHooks) ShouldPullImage(pod *api.Pod, container *api.Cont
return false
}
func (kr *kubeletRuntimeHooks) ReportImagePull(pod *api.Pod, container *api.Container, err error) {
func (kr *kubeletRuntimeHooks) ReportImagePull(pod *api.Pod, container *api.Container, pullError error) {
ref, err := kubecontainer.GenerateContainerRef(pod, container)
if err != nil {
glog.Errorf("Couldn't make a ref to pod %v, container %v: '%v'", pod.Name, container.Name, err)
glog.Errorf("Couldn't make a ref to pod %q, container %q: '%v'", pod.Name, container.Name, err)
return
}
if err != nil {
kr.recorder.Eventf(ref, "failed", "Failed to pull image %q: %v", container.Image, err)
if pullError != nil {
kr.recorder.Eventf(ref, "failed", "Failed to pull image %q: %v", container.Image, pullError)
} else {
kr.recorder.Eventf(ref, "pulled", "Successfully pulled image %q", container.Image)
}