Add a limit range resource

pkg/api/validation/validation.go

@@ -640,3 +640,29 @@ func ValidateResourceName(str string) errs.ValidationErrorList {
 
 	return errs.ValidationErrorList{}
 }
+
+// ValidateLimitRange tests if required fields in the LimitRange are set.
+func ValidateLimitRange(limitRange *api.LimitRange) errs.ValidationErrorList {
+	allErrs := errs.ValidationErrorList{}
+	if len(limitRange.Name) == 0 {
+		allErrs = append(allErrs, errs.NewFieldRequired("name", limitRange.Name))
+	} else if !util.IsDNSSubdomain(limitRange.Name) {
+		allErrs = append(allErrs, errs.NewFieldInvalid("name", limitRange.Name, ""))
+	}
+	if len(limitRange.Namespace) == 0 {
+		allErrs = append(allErrs, errs.NewFieldRequired("namespace", limitRange.Namespace))
+	} else if !util.IsDNSSubdomain(limitRange.Namespace) {
+		allErrs = append(allErrs, errs.NewFieldInvalid("namespace", limitRange.Namespace, ""))
+	}
+	// ensure resource names are properly qualified per docs/resources.md
+	for i := range limitRange.Spec.Limits {
+		limit := limitRange.Spec.Limits[i]
+		for k, _ := range limit.Max {
+			allErrs = append(allErrs, ValidateResourceName(k))
+		}
+		for k, _ := range limit.Min {
+			allErrs = append(allErrs, ValidateResourceName(k))
+		}
+	}
+	return allErrs
+}

pkg/api/validation/validation_test.go

@@ -1552,3 +1552,92 @@ func TestValidateResourceNames(t *testing.T) {
 		}
 	}
 }
+
+func TestValidateLimitRange(t *testing.T) {
+	successCases := []api.LimitRange{
+		{
+			ObjectMeta: api.ObjectMeta{
+				Name:      "abc",
+				Namespace: "foo",
+			},
+			Spec: api.LimitRangeSpec{
+				Limits: []api.LimitRangeItem{
+					{
+						Kind: "pods",
+						Max: api.ResourceList{
+							api.ResourceCPU:    resource.MustParse("100"),
+							api.ResourceMemory: resource.MustParse("10000"),
+						},
+						Min: api.ResourceList{
+							api.ResourceCPU:    resource.MustParse("0"),
+							api.ResourceMemory: resource.MustParse("100"),
+						},
+					},
+				},
+			},
+		},
+	}
+	for _, successCase := range successCases {
+		if errs := ValidateLimitRange(&successCase); len(errs) != 0 {
+			t.Errorf("expected success: %v", errs)
+		}
+	}
+
+	errorCases := map[string]api.LimitRange{
+		"zero-length Name": {
+			ObjectMeta: api.ObjectMeta{
+				Name:      "",
+				Namespace: "foo",
+			},
+			Spec: api.LimitRangeSpec{
+				Limits: []api.LimitRangeItem{
+					{
+						Kind: "pods",
+						Max: api.ResourceList{
+							api.ResourceCPU:    resource.MustParse("100"),
+							api.ResourceMemory: resource.MustParse("10000"),
+						},
+						Min: api.ResourceList{
+							api.ResourceCPU:    resource.MustParse("0"),
+							api.ResourceMemory: resource.MustParse("100"),
+						},
+					},
+				},
+			},
+		},
+		"zero-length-namespace": {
+			ObjectMeta: api.ObjectMeta{
+				Name:      "abc",
+				Namespace: "",
+			},
+			Spec: api.LimitRangeSpec{
+				Limits: []api.LimitRangeItem{
+					{
+						Kind: "pods",
+						Max: api.ResourceList{
+							api.ResourceCPU:    resource.MustParse("100"),
+							api.ResourceMemory: resource.MustParse("10000"),
+						},
+						Min: api.ResourceList{
+							api.ResourceCPU:    resource.MustParse("0"),
+							api.ResourceMemory: resource.MustParse("100"),
+						},
+					},
+				},
+			},
+		},
+	}
+	for k, v := range errorCases {
+		errs := ValidateLimitRange(&v)
+		if len(errs) == 0 {
+			t.Errorf("expected failure for %s", k)
+		}
+		for i := range errs {
+			field := errs[i].(*errors.ValidationError).Field
+			if field != "name" &&
+				field != "namespace" {
+				t.Errorf("%s: missing prefix for: %v", k, errs[i])
+			}
+		}
+	}
+}