github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #122589 from pohly/log-contextual-beta

Browse Source 
promote contextual logging to beta, enabled by default
This commit is contained in:
Kubernetes Prow Robot
2024-02-26 13:56:13 -08:00
committed by GitHub
parent 5d527dcf12 9c6b42af46
commit 0a1cb2a4a4
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
staging/src/k8s.io/component-base/logs/api/v1/kube_features.go
View File

@@ -24,15 +24,17 @@ const (
// owner: @pohly // owner: @pohly
// kep: https://kep.k8s.io/3077 // kep: https://kep.k8s.io/3077
// alpha: v1.24 // alpha: v1.24
// beta: v1.30
// //
// Enables looking up a logger from a context.Context instead of using // Enables looking up a logger from a context.Context instead of using
// the global fallback logger and manipulating the logger that is // the global fallback logger and manipulating the logger that is
// used by a call chain. // used by a call chain.
ContextualLogging featuregate.Feature = "ContextualLogging" ContextualLogging featuregate.Feature = "ContextualLogging"
// contextualLoggingDefault must remain false while in alpha. It can // contextualLoggingDefault is now true because the feature reached beta
// become true in beta. // and performance comparisons showed no relevant degradation when
contextualLoggingDefault = false // enabling it.
contextualLoggingDefault = true
// Allow fine-tuning of experimental, alpha-quality logging options. // Allow fine-tuning of experimental, alpha-quality logging options.
// //
@@ -57,7 +59,7 @@ const (
func featureGates() map[featuregate.Feature]featuregate.FeatureSpec { func featureGates() map[featuregate.Feature]featuregate.FeatureSpec {
return map[featuregate.Feature]featuregate.FeatureSpec{ return map[featuregate.Feature]featuregate.FeatureSpec{
ContextualLogging: {Default: contextualLoggingDefault, PreRelease: featuregate.Alpha}, ContextualLogging: {Default: contextualLoggingDefault, PreRelease: featuregate.Beta},
LoggingAlphaOptions: {Default: false, PreRelease: featuregate.Alpha}, LoggingAlphaOptions: {Default: false, PreRelease: featuregate.Alpha},
LoggingBetaOptions: {Default: true, PreRelease: featuregate.Beta}, LoggingBetaOptions: {Default: true, PreRelease: featuregate.Beta},