TCPSocket could not be used as it was not checked in validation
Attempting to use it gave the error "must register one handler". Added more tests for it.
This commit is contained in:
@@ -496,6 +496,32 @@ func TestValidateContainers(t *testing.T) {
|
|||||||
ImagePullPolicy: "IfNotPresent",
|
ImagePullPolicy: "IfNotPresent",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
|
"invalid lifecycle, no tcp socket port.": {
|
||||||
|
{
|
||||||
|
Name: "life-123",
|
||||||
|
Image: "image",
|
||||||
|
Lifecycle: &api.Lifecycle{
|
||||||
|
PreStop: &api.Handler{
|
||||||
|
TCPSocket: &api.TCPSocketAction{},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
ImagePullPolicy: "IfNotPresent",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
"invalid lifecycle, zero tcp socket port.": {
|
||||||
|
{
|
||||||
|
Name: "life-123",
|
||||||
|
Image: "image",
|
||||||
|
Lifecycle: &api.Lifecycle{
|
||||||
|
PreStop: &api.Handler{
|
||||||
|
TCPSocket: &api.TCPSocketAction{
|
||||||
|
Port: util.IntOrString{IntVal: 0},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
ImagePullPolicy: "IfNotPresent",
|
||||||
|
},
|
||||||
|
},
|
||||||
"invalid lifecycle, no action.": {
|
"invalid lifecycle, no action.": {
|
||||||
{
|
{
|
||||||
Name: "life-123",
|
Name: "life-123",
|
||||||
@@ -506,6 +532,28 @@ func TestValidateContainers(t *testing.T) {
|
|||||||
ImagePullPolicy: "IfNotPresent",
|
ImagePullPolicy: "IfNotPresent",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
|
"invalid liveness probe, no tcp socket port.": {
|
||||||
|
{
|
||||||
|
Name: "life-123",
|
||||||
|
Image: "image",
|
||||||
|
LivenessProbe: &api.Probe{
|
||||||
|
Handler: api.Handler{
|
||||||
|
TCPSocket: &api.TCPSocketAction{},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
ImagePullPolicy: "IfNotPresent",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
"invalid liveness probe, no action.": {
|
||||||
|
{
|
||||||
|
Name: "life-123",
|
||||||
|
Image: "image",
|
||||||
|
LivenessProbe: &api.Probe{
|
||||||
|
Handler: api.Handler{},
|
||||||
|
},
|
||||||
|
ImagePullPolicy: "IfNotPresent",
|
||||||
|
},
|
||||||
|
},
|
||||||
"privilege disabled": {
|
"privilege disabled": {
|
||||||
{Name: "abc", Image: "image", Privileged: true},
|
{Name: "abc", Image: "image", Privileged: true},
|
||||||
},
|
},
|
||||||
|
Reference in New Issue
Block a user