github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a regression that scheduler always go through all Filter plugins

Browse Source 
The correct behavior is to stop upon the first Filter failure.
This commit is contained in:
Wei Huang
2022-12-15 12:00:55 -08:00
parent 3d3a180713
commit 0aecf6b3d5
2 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/scheduler/framework/runtime/framework.go
View File

@@ -730,11 +730,10 @@ func (f *frameworkImpl) RunFilterPlugins(
if !pluginStatus.IsUnschedulable() {
// Filter plugins are not supposed to return any status other than
// Success or Unschedulable.
errStatus := framework.AsStatus(fmt.Errorf("running %q filter plugin: %w", pl.Name(), pluginStatus.AsError())).WithFailedPlugin(pl.Name())
return map[string]*framework.Status{pl.Name(): errStatus}
pluginStatus = framework.AsStatus(fmt.Errorf("running %q filter plugin: %w", pl.Name(), pluginStatus.AsError()))
}
pluginStatus.SetFailedPlugin(pl.Name())
statuses[pl.Name()] = pluginStatus
return map[string]*framework.Status{pl.Name(): pluginStatus}
}
}