Stop using binaryVersion=0.0 in tests and delete fixtures for kinds no longer served.
This commit is contained in:
		@@ -30,6 +30,8 @@ import (
 | 
			
		||||
 | 
			
		||||
	clientv3 "go.etcd.io/etcd/client/v3"
 | 
			
		||||
 | 
			
		||||
	"sigs.k8s.io/yaml"
 | 
			
		||||
 | 
			
		||||
	appsv1 "k8s.io/api/apps/v1"
 | 
			
		||||
	batchv1 "k8s.io/api/batch/v1"
 | 
			
		||||
	corev1 "k8s.io/api/core/v1"
 | 
			
		||||
@@ -52,7 +54,6 @@ import (
 | 
			
		||||
	"k8s.io/kubernetes/test/integration/framework"
 | 
			
		||||
	"k8s.io/kubernetes/test/utils/ktesting"
 | 
			
		||||
	"k8s.io/utils/pointer"
 | 
			
		||||
	"sigs.k8s.io/yaml"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
const (
 | 
			
		||||
@@ -116,7 +117,7 @@ func newTransformTest(tb testing.TB, transformerConfigYAML string, reload bool,
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	if e.kubeAPIServer, err = kubeapiservertesting.StartTestServer(
 | 
			
		||||
		tb, &kubeapiservertesting.TestServerInstanceOptions{BinaryVersion: "0.0"},
 | 
			
		||||
		tb, nil,
 | 
			
		||||
		e.getEncryptionOptions(reload), e.storageConfig); err != nil {
 | 
			
		||||
		e.cleanUp()
 | 
			
		||||
		return nil, fmt.Errorf("failed to start KubeAPI server: %w", err)
 | 
			
		||||
 
 | 
			
		||||
@@ -230,38 +230,6 @@ func GetEtcdStorageDataForNamespace(namespace string) map[schema.GroupVersionRes
 | 
			
		||||
		},
 | 
			
		||||
		// --
 | 
			
		||||
 | 
			
		||||
		// k8s.io/kubernetes/pkg/apis/flowcontrol/v1beta1
 | 
			
		||||
		gvr("flowcontrol.apiserver.k8s.io", "v1beta1", "flowschemas"): {
 | 
			
		||||
			Stub:             `{"metadata": {"name": "va2"}, "spec": {"priorityLevelConfiguration": {"name": "name1"}}}`,
 | 
			
		||||
			ExpectedEtcdPath: "/registry/flowschemas/va2",
 | 
			
		||||
			ExpectedGVK:      gvkP("flowcontrol.apiserver.k8s.io", "v1", "FlowSchema"),
 | 
			
		||||
		},
 | 
			
		||||
		// --
 | 
			
		||||
 | 
			
		||||
		// k8s.io/kubernetes/pkg/apis/flowcontrol/v1beta1
 | 
			
		||||
		gvr("flowcontrol.apiserver.k8s.io", "v1beta1", "prioritylevelconfigurations"): {
 | 
			
		||||
			Stub:             `{"metadata": {"name": "conf2"}, "spec": {"type": "Limited", "limited": {"assuredConcurrencyShares":3, "limitResponse": {"type": "Reject"}}}}`,
 | 
			
		||||
			ExpectedEtcdPath: "/registry/prioritylevelconfigurations/conf2",
 | 
			
		||||
			ExpectedGVK:      gvkP("flowcontrol.apiserver.k8s.io", "v1", "PriorityLevelConfiguration"),
 | 
			
		||||
		},
 | 
			
		||||
		// --
 | 
			
		||||
 | 
			
		||||
		// k8s.io/kubernetes/pkg/apis/flowcontrol/v1beta2
 | 
			
		||||
		gvr("flowcontrol.apiserver.k8s.io", "v1beta2", "flowschemas"): {
 | 
			
		||||
			Stub:             `{"metadata": {"name": "fs-1"}, "spec": {"priorityLevelConfiguration": {"name": "name1"}}}`,
 | 
			
		||||
			ExpectedEtcdPath: "/registry/flowschemas/fs-1",
 | 
			
		||||
			ExpectedGVK:      gvkP("flowcontrol.apiserver.k8s.io", "v1", "FlowSchema"),
 | 
			
		||||
		},
 | 
			
		||||
		// --
 | 
			
		||||
 | 
			
		||||
		// k8s.io/kubernetes/pkg/apis/flowcontrol/v1beta2
 | 
			
		||||
		gvr("flowcontrol.apiserver.k8s.io", "v1beta2", "prioritylevelconfigurations"): {
 | 
			
		||||
			Stub:             `{"metadata": {"name": "conf3"}, "spec": {"type": "Limited", "limited": {"assuredConcurrencyShares":3, "limitResponse": {"type": "Reject"}}}}`,
 | 
			
		||||
			ExpectedEtcdPath: "/registry/prioritylevelconfigurations/conf3",
 | 
			
		||||
			ExpectedGVK:      gvkP("flowcontrol.apiserver.k8s.io", "v1", "PriorityLevelConfiguration"),
 | 
			
		||||
		},
 | 
			
		||||
		// --
 | 
			
		||||
 | 
			
		||||
		// k8s.io/kubernetes/pkg/apis/flowcontrol/v1beta3
 | 
			
		||||
		gvr("flowcontrol.apiserver.k8s.io", "v1beta3", "flowschemas"): {
 | 
			
		||||
			Stub:             `{"metadata": {"name": "fs-2"}, "spec": {"priorityLevelConfiguration": {"name": "name1"}}}`,
 | 
			
		||||
 
 | 
			
		||||
@@ -27,26 +27,15 @@ import (
 | 
			
		||||
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 | 
			
		||||
	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 | 
			
		||||
	"k8s.io/apimachinery/pkg/runtime/schema"
 | 
			
		||||
	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 | 
			
		||||
	"k8s.io/apimachinery/pkg/util/sets"
 | 
			
		||||
	"k8s.io/apimachinery/pkg/watch"
 | 
			
		||||
	"k8s.io/apiserver/pkg/storage"
 | 
			
		||||
	utilfeature "k8s.io/apiserver/pkg/util/feature"
 | 
			
		||||
	utilversion "k8s.io/apiserver/pkg/util/version"
 | 
			
		||||
	"k8s.io/client-go/dynamic"
 | 
			
		||||
	"k8s.io/kubernetes/cmd/kube-apiserver/app/options"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
// TestCrossGroupStorage tests to make sure that all objects stored in an expected location in etcd can be converted/read.
 | 
			
		||||
func TestCrossGroupStorage(t *testing.T) {
 | 
			
		||||
	testRegistry := utilversion.NewComponentGlobalsRegistry()
 | 
			
		||||
	utilruntime.Must(testRegistry.Register("test", utilversion.NewEffectiveVersion("0.0"), utilfeature.DefaultFeatureGate.DeepCopy()))
 | 
			
		||||
 | 
			
		||||
	apiServer := StartRealAPIServerOrDie(t, func(opts *options.ServerRunOptions) {
 | 
			
		||||
		// force enable all resources so we can check storage.
 | 
			
		||||
		opts.GenericServerRunOptions.ComponentName = "test"
 | 
			
		||||
		opts.GenericServerRunOptions.ComponentGlobalsRegistry = testRegistry
 | 
			
		||||
	})
 | 
			
		||||
	apiServer := StartRealAPIServerOrDie(t)
 | 
			
		||||
	defer apiServer.Cleanup()
 | 
			
		||||
 | 
			
		||||
	etcdStorageData := GetEtcdStorageData()
 | 
			
		||||
 
 | 
			
		||||
@@ -34,13 +34,10 @@ import (
 | 
			
		||||
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 | 
			
		||||
	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 | 
			
		||||
	"k8s.io/apimachinery/pkg/runtime/schema"
 | 
			
		||||
	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 | 
			
		||||
	"k8s.io/apimachinery/pkg/util/sets"
 | 
			
		||||
	"k8s.io/apiserver/pkg/util/feature"
 | 
			
		||||
	utilversion "k8s.io/apiserver/pkg/util/version"
 | 
			
		||||
	"k8s.io/client-go/dynamic"
 | 
			
		||||
	featuregatetesting "k8s.io/component-base/featuregate/testing"
 | 
			
		||||
	"k8s.io/kubernetes/cmd/kube-apiserver/app/options"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
// Only add kinds to this list when this a virtual resource with get and create verbs that doesn't actually
 | 
			
		||||
@@ -76,13 +73,8 @@ var allowMissingTestdataFixtures = map[schema.GroupVersionKind]bool{
 | 
			
		||||
func TestEtcdStoragePath(t *testing.T) {
 | 
			
		||||
	featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, "AllAlpha", true)
 | 
			
		||||
	featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, "AllBeta", true)
 | 
			
		||||
	testRegistry := utilversion.NewComponentGlobalsRegistry()
 | 
			
		||||
	utilruntime.Must(testRegistry.Register("test", utilversion.NewEffectiveVersion("0.0"), feature.DefaultFeatureGate.DeepCopy()))
 | 
			
		||||
 | 
			
		||||
	apiServer := StartRealAPIServerOrDie(t, func(opts *options.ServerRunOptions) {
 | 
			
		||||
		opts.GenericServerRunOptions.ComponentName = "test"
 | 
			
		||||
		opts.GenericServerRunOptions.ComponentGlobalsRegistry = testRegistry
 | 
			
		||||
	})
 | 
			
		||||
	apiServer := StartRealAPIServerOrDie(t)
 | 
			
		||||
	defer apiServer.Cleanup()
 | 
			
		||||
	defer dumpEtcdKVOnFailure(t, apiServer.KV)
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user