fix: enable bool-compare rule from testifylint linter (#125135)

* fix: enable bool-compare rule from testifylint linter

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update hack/golangci.yaml.in

Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>

* Update golangci.yaml.in

* Update golangci-strict.yaml

* Update golangci.yaml.in

* Update golangci.yaml.in

* Update golangci.yaml.in

* Update golangci.yaml.in

* Update golangci.yaml

* Update golangci-hints.yaml

* Update golangci-strict.yaml

* Update golangci.yaml.in

* Update golangci.yaml

* Update mux_test.go

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>

hack/golangci-hints.yaml

@@ -90,6 +90,7 @@ linters:
     - revive
     - staticcheck
     - stylecheck
+    - testifylint
     - unused
 
 linters-settings: # please keep this alphabetized
@@ -179,3 +180,5 @@ linters-settings: # please keep this alphabetized
   staticcheck:
     checks:
       - "all"
+  testifylint:
+    enable-all: true

hack/golangci-strict.yaml

@@ -133,6 +133,7 @@ linters:
     - revive
     - staticcheck
     - stylecheck
+    - testifylint
     - unused
   disable:
     # https://github.com/kubernetes/kubernetes/issues/117288#issuecomment-1507008359
@@ -219,3 +220,5 @@ linters-settings: # please keep this alphabetized
   staticcheck:
     checks:
       - "all"
+  testifylint:
+    enable-all: true

hack/golangci.yaml

@@ -139,6 +139,7 @@ linters:
     - revive
     - staticcheck
     - stylecheck
+    - testifylint
     - unused
 
 linters-settings: # please keep this alphabetized
@@ -231,3 +232,17 @@ linters-settings: # please keep this alphabetized
   stylecheck:
     checks:
       - "ST1019"   # Importing the same package multiple times
+  testifylint:
+    enable-all: true
+    disable:  # TODO: remove each disabled rule and fix it
+      - blank-import
+      - compares
+      - empty
+      - error-is-as
+      - error-nil
+      - expected-actual
+      - float-compare
+      - go-require
+      - len
+      - nil-compare
+      - require-error

hack/golangci.yaml.in

@@ -148,6 +148,7 @@ linters:
     - revive
     - staticcheck
     - stylecheck
+    - testifylint
     - unused
   {{- if .Strict}}
   disable:
@@ -206,3 +207,19 @@ linters-settings: # please keep this alphabetized
     checks:
       - "ST1019"   # Importing the same package multiple times
   {{- end}}
+  testifylint:
+    enable-all: true
+    {{- if .Base}}
+    disable:  # TODO: remove each disabled rule and fix it
+      - blank-import
+      - compares
+      - empty
+      - error-is-as
+      - error-nil
+      - expected-actual
+      - float-compare
+      - go-require
+      - len
+      - nil-compare
+      - require-error
+    {{- end}}