Revert "Merge pull request #118895 from RyanAoh/kep-1860"

This reverts commit 890a6c8f70, reversing
changes made to 4f60a8d493.

pkg/apis/core/validation/validation_test.go

@@ -23368,87 +23368,3 @@ func TestValidateDynamicResourceAllocation(t *testing.T) {
 		}
 	})
 }
-
-func TestValidateLoadBalancerStatus(t *testing.T) {
-	ipModeVIP := core.LoadBalancerIPModeVIP
-	ipModeProxy := core.LoadBalancerIPModeProxy
-	ipModeDummy := core.LoadBalancerIPMode("dummy")
-
-	testCases := []struct {
-		name          string
-		ipModeEnabled bool
-		tweakLBStatus func(s *core.LoadBalancerStatus)
-		numErrs       int
-	}{
-		/* LoadBalancerIPMode*/
-		{
-			name:          "valid vip ipMode",
-			ipModeEnabled: true,
-			tweakLBStatus: func(s *core.LoadBalancerStatus) {
-				s.Ingress = []core.LoadBalancerIngress{{
-					IP:     "1.2.3.4",
-					IPMode: &ipModeVIP,
-				}}
-			},
-			numErrs: 0,
-		}, {
-			name:          "valid proxy ipMode",
-			ipModeEnabled: true,
-			tweakLBStatus: func(s *core.LoadBalancerStatus) {
-				s.Ingress = []core.LoadBalancerIngress{{
-					IP:     "1.2.3.4",
-					IPMode: &ipModeProxy,
-				}}
-			},
-			numErrs: 0,
-		}, {
-			name:          "invalid ipMode",
-			ipModeEnabled: true,
-			tweakLBStatus: func(s *core.LoadBalancerStatus) {
-				s.Ingress = []core.LoadBalancerIngress{{
-					IP:     "1.2.3.4",
-					IPMode: &ipModeDummy,
-				}}
-			},
-			numErrs: 1,
-		}, {
-			name:          "missing ipMode with LoadbalancerIPMode enabled",
-			ipModeEnabled: true,
-			tweakLBStatus: func(s *core.LoadBalancerStatus) {
-				s.Ingress = []core.LoadBalancerIngress{{
-					IP: "1.2.3.4",
-				}}
-			},
-			numErrs: 1,
-		}, {
-			name:          "missing ipMode with LoadbalancerIPMode disabled",
-			ipModeEnabled: false,
-			tweakLBStatus: func(s *core.LoadBalancerStatus) {
-				s.Ingress = []core.LoadBalancerIngress{{
-					IP: "1.2.3.4",
-				}}
-			},
-			numErrs: 0,
-		}, {
-			name:          "missing ip with ipMode present",
-			ipModeEnabled: true,
-			tweakLBStatus: func(s *core.LoadBalancerStatus) {
-				s.Ingress = []core.LoadBalancerIngress{{
-					IPMode: &ipModeProxy,
-				}}
-			},
-			numErrs: 1,
-		},
-	}
-	for _, tc := range testCases {
-		t.Run(tc.name, func(t *testing.T) {
-			defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.LoadBalancerIPMode, tc.ipModeEnabled)()
-			s := core.LoadBalancerStatus{}
-			tc.tweakLBStatus(&s)
-			errs := ValidateLoadBalancerStatus(&s, field.NewPath("status"))
-			if len(errs) != tc.numErrs {
-				t.Errorf("Unexpected error list for case %q(expected:%v got %v) - Errors:\n %v", tc.name, tc.numErrs, len(errs), errs.ToAggregate())
-			}
-		})
-	}
-}