From 0e78dd2d17b0fe314780005d6e06a21822fb34ff Mon Sep 17 00:00:00 2001
From: danielqsj <qsj.daniel@gmail.com>
Date: Mon, 11 Feb 2019 16:47:12 +0800
Subject: [PATCH] fix shellcheck in pkg/util/verify-util-pkg.sh

---
 hack/.shellcheck_failures   | 1 -
 pkg/util/verify-util-pkg.sh | 6 +++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index fb2d2ab948b..d1538e293ab 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -120,7 +120,6 @@
 ./hack/verify-test-owners.sh
 ./hack/verify-typecheck.sh
 ./pkg/kubectl/cmd/edit/testdata/record_testcase.sh
-./pkg/util/verify-util-pkg.sh
 ./test/cmd/apply.sh
 ./test/cmd/apps.sh
 ./test/cmd/authorization.sh
diff --git a/pkg/util/verify-util-pkg.sh b/pkg/util/verify-util-pkg.sh
index 5c1fbecc71d..92f4dedd1fb 100755
--- a/pkg/util/verify-util-pkg.sh
+++ b/pkg/util/verify-util-pkg.sh
@@ -21,7 +21,7 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-BASH_DIR=$(dirname "${BASH_SOURCE}")
+BASH_DIR=$(dirname "${BASH_SOURCE[0]}")
 
 find_go_files() {
   find . -maxdepth 1 -not \( \
@@ -34,8 +34,8 @@ find_go_files() {
 ret=0
 
 pushd "${BASH_DIR}" > /dev/null
-  for path in `find_go_files`; do
-    file=$(basename $path)
+  for path in $(find_go_files); do
+    file=$(basename "$path")
     echo "Found pkg/util/${file}, but should be moved into util sub-pkgs." 1>&2
     ret=1
   done