github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename a bunch of "Make" functions to "New"

Browse Source 
Also rename some to other names that make better reading.  There are still a
bunch of "make" functions but they do things like assemble a string from parts
or build an array of things.  It seemed that "make" there seemed fine.  "New"
is for "constructors".
This commit is contained in:
Tim Hockin
2014-08-20 21:27:19 -07:00
parent 953cd923f1
commit 0f97a73c1b
33 changed files with 217 additions and 217 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/util/util_test.go
View File

@@ -34,7 +34,7 @@ type FakePod struct {
Str string
}
func TestMakeJSONString(t *testing.T) {
func TestEncodeJSON(t *testing.T) {
pod := FakePod{
FakeJSONBase: FakeJSONBase{ID: "foo"},
Labels: map[string]string{
@@ -45,7 +45,7 @@ func TestMakeJSONString(t *testing.T) {
Str: "a string",
}
body := MakeJSONString(pod)
body := EncodeJSON(pod)
expectedBody, err := json.Marshal(pod)
if err != nil {
@@ -72,15 +72,15 @@ func TestHandleCrash(t *testing.T) {
}
}
func TestMakeIntOrStringFromInt(t *testing.T) {
i := MakeIntOrStringFromInt(93)
func TestNewIntOrStringFromInt(t *testing.T) {
i := NewIntOrStringFromInt(93)
if i.Kind != IntstrInt || i.IntVal != 93 {
t.Errorf("Expected IntVal=93, got %+v", i)
}
}
func TestMakeIntOrStringFromString(t *testing.T) {
i := MakeIntOrStringFromString("76")
func TestNewIntOrStringFromString(t *testing.T) {
i := NewIntOrStringFromString("76")
if i.Kind != IntstrString || i.StrVal != "76" {
t.Errorf("Expected StrVal=\"76\", got %+v", i)
}