github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #125518 from pohly/scheduler-perf-cleanup-fix

Browse Source 
scheduler_perf: shut down apiserver clients before apiserver
This commit is contained in:
Kubernetes Prow Robot
2024-06-16 10:03:29 -07:00
committed by GitHub
parent 9de747cc01 246e2aedf5
commit 0fd6746b2a
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/integration/scheduler_perf/util.go
View File

@@ -98,11 +98,10 @@ func mustSetupCluster(tCtx ktesting.TContext, config *config.KubeSchedulerConfig
if err != nil { if err != nil {
tCtx.Fatalf("start apiserver: %v", err) tCtx.Fatalf("start apiserver: %v", err)
} }
// Cleanup will be in reverse order: first the clients by canceling the
// child context (happens automatically), then the server.
tCtx.Cleanup(server.TearDownFn) tCtx.Cleanup(server.TearDownFn)
tCtx = ktesting.WithCancel(tCtx)
// Cleanup will be in reverse order: first the clients get cancelled,
// then the apiserver is torn down via the automatic cancelation of
// tCtx.
// TODO: client connection configuration, such as QPS or Burst is configurable in theory, this could be derived from the `config`, need to // TODO: client connection configuration, such as QPS or Burst is configurable in theory, this could be derived from the `config`, need to
// support this when there is any testcase that depends on such configuration. // support this when there is any testcase that depends on such configuration.