github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cleanup the use of ExternalID as it is deprecated

Browse Source 
The patch removes ExternalID usage from node_controller
and node_lifecycle_oontroller. The code instead uses InstanceID
which returns the cloud provider ID as well.
This commit is contained in:
Anup Navare
2018-03-01 22:22:28 -08:00
parent 1102fd0dcb
commit 1335e6e2d4
16 changed files with 8 additions and 128 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/controller/util/node/controller_utils.go
View File

@@ -178,7 +178,7 @@ func ExistsInCloudProvider(cloud cloudprovider.Interface, nodeName types.NodeNam
if !ok {
return false, fmt.Errorf("%v", ErrCloudInstance)
}
if _, err := instances.ExternalID(context.TODO(), nodeName); err != nil {
if _, err := instances.InstanceID(context.TODO(), nodeName); err != nil {
if err == cloudprovider.InstanceNotFound {
return false, nil
}