e2e: use error wrapping with %w
The recently introduced failure handling in ExpectNoError depends on error wrapping: if an error prefix gets added with `fmt.Errorf("foo: %v", err)`, then ExpectNoError cannot detect that the root cause is an assertion failure and then will add another useless "unexpected error" prefix and will not dump the additional failure information (currently the backtrace inside the E2E framework). Instead of manually deciding on a case-by-case basis where %w is needed, all error wrapping was updated automatically with sed -i "s/fmt.Errorf\(.*\): '*\(%s\|%v\)'*\",\(.* err)\)/fmt.Errorf\1: %w\",\3/" $(git grep -l 'fmt.Errorf' test/e2e*) This may be unnecessary in some cases, but it's not wrong.
This commit is contained in:
@@ -31,7 +31,7 @@ func runCmd(cmd string, args []string) error {
|
||||
func getMatchingLineFromLog(log string, pattern string) (line string, err error) {
|
||||
regex, err := regexp.Compile(pattern)
|
||||
if err != nil {
|
||||
return line, fmt.Errorf("failed to compile regexp %v: %v", pattern, err)
|
||||
return line, fmt.Errorf("failed to compile regexp %v: %w", pattern, err)
|
||||
}
|
||||
|
||||
logLines := strings.Split(log, "\n")
|
||||
|
Reference in New Issue
Block a user