From 746bca241f3a0f8535a3a25e72f245360deee4bf Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Mon, 14 May 2018 00:35:33 -0400 Subject: [PATCH] print result object from kubectl taint correctly --- hack/make-rules/test-cmd-util.sh | 11 +++++++++++ pkg/kubectl/cmd/taint.go | 1 + 2 files changed, 12 insertions(+) diff --git a/hack/make-rules/test-cmd-util.sh b/hack/make-rules/test-cmd-util.sh index 5c60b50e931..acea42c3f6e 100755 --- a/hack/make-rules/test-cmd-util.sh +++ b/hack/make-rules/test-cmd-util.sh @@ -4617,6 +4617,17 @@ __EOF__ } __EOF__ + # taint/untaint + # Pre-condition: node has no taints + kube::test::get_object_assert "nodes 127.0.0.1" "{{.spec.taints}}" '' + # taint can add a taint + kubectl taint node 127.0.0.1 dedicated=foo:PreferNoSchedule + kube::test::get_object_assert "nodes 127.0.0.1" '{{range .spec.taints}}{{.effect}}{{end}}' 'PreferNoSchedule' + # taint can remove a taint + kubectl taint node 127.0.0.1 dedicated- + # Post-condition: node has no taints + kube::test::get_object_assert "nodes 127.0.0.1" "{{.spec.taints}}" '' + ### kubectl cordon update with --dry-run does not mark node unschedulable # Pre-condition: node is schedulable kube::test::get_object_assert "nodes 127.0.0.1" "{{.spec.unschedulable}}" '' diff --git a/pkg/kubectl/cmd/taint.go b/pkg/kubectl/cmd/taint.go index 5437dd8ce42..d5210d541c3 100644 --- a/pkg/kubectl/cmd/taint.go +++ b/pkg/kubectl/cmd/taint.go @@ -290,6 +290,7 @@ func (o TaintOptions) RunTaint() error { if err != nil { return err } + outputObj = cmdutil.AsDefaultVersionedOrOriginal(outputObj, mapping) printer, err := o.ToPrinter(operation) if err != nil {