github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #105605 from sttts/sttts-watch-cache-multiple-blockers

Browse Source 
apiserver/watchcache: doc watch event fan-out to blocked watchers better
This commit is contained in:
Kubernetes Prow Robot
2021-10-11 09:32:40 -07:00
committed by GitHub
parent dc9c571166 94b2bb1d3d
commit 194a3dea5d
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
staging/src/k8s.io/apiserver/pkg/storage/cacher/cacher.go
View File

@@ -934,8 +934,11 @@ func (c *Cacher) dispatchEvent(event *watchCacheEvent) {
timeout := c.dispatchTimeoutBudget.takeAvailable() timeout := c.dispatchTimeoutBudget.takeAvailable()
c.timer.Reset(timeout) c.timer.Reset(timeout)
// Make sure every watcher will try to send event without blocking first, // Send event to all blocked watchers. As long as timer is running,
// even if the timer has already expired. // `add` will wait for the watcher to unblock. After timeout,
// `add` will not wait, but immediately close a still blocked watcher.
// Hence, every watcher gets the chance to unblock itself while timer
// is running, not only the first ones in the list.
timer := c.timer timer := c.timer
for _, watcher := range c.blockedWatchers { for _, watcher := range c.blockedWatchers {
if !watcher.add(event, timer) { if !watcher.add(event, timer) {