Add some more synchronization.
This commit is contained in:
parent
51c5907c55
commit
1a3e4f8baf
@ -36,6 +36,8 @@ type FakeDockerClient struct {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (f *FakeDockerClient) clearCalls() {
|
func (f *FakeDockerClient) clearCalls() {
|
||||||
|
f.lock.Lock()
|
||||||
|
defer f.lock.Unlock()
|
||||||
f.called = []string{}
|
f.called = []string{}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -19,6 +19,7 @@ package registry
|
|||||||
import (
|
import (
|
||||||
"fmt"
|
"fmt"
|
||||||
"strings"
|
"strings"
|
||||||
|
"sync"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"code.google.com/p/go-uuid/uuid"
|
"code.google.com/p/go-uuid/uuid"
|
||||||
@ -40,6 +41,7 @@ type PodRegistryStorage struct {
|
|||||||
minionLister scheduler.MinionLister
|
minionLister scheduler.MinionLister
|
||||||
cloud cloudprovider.Interface
|
cloud cloudprovider.Interface
|
||||||
podPollPeriod time.Duration
|
podPollPeriod time.Duration
|
||||||
|
lock sync.Mutex
|
||||||
}
|
}
|
||||||
|
|
||||||
// MakePodRegistryStorage makes a RESTStorage object for a pod registry.
|
// MakePodRegistryStorage makes a RESTStorage object for a pod registry.
|
||||||
@ -193,6 +195,17 @@ func (storage *PodRegistryStorage) Extract(body []byte) (interface{}, error) {
|
|||||||
return pod, err
|
return pod, err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (storage *PodRegistryStorage) scheduleAndCreatePod(pod api.Pod) error {
|
||||||
|
storage.lock.Lock()
|
||||||
|
defer storage.lock.Unlock()
|
||||||
|
// TODO(lavalamp): Separate scheduler more cleanly.
|
||||||
|
machine, err := storage.scheduler.Schedule(pod, storage.minionLister)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
return storage.registry.CreatePod(machine, pod)
|
||||||
|
}
|
||||||
|
|
||||||
func (storage *PodRegistryStorage) Create(obj interface{}) (<-chan interface{}, error) {
|
func (storage *PodRegistryStorage) Create(obj interface{}) (<-chan interface{}, error) {
|
||||||
pod := obj.(api.Pod)
|
pod := obj.(api.Pod)
|
||||||
if len(pod.ID) == 0 {
|
if len(pod.ID) == 0 {
|
||||||
@ -201,12 +214,7 @@ func (storage *PodRegistryStorage) Create(obj interface{}) (<-chan interface{},
|
|||||||
pod.DesiredState.Manifest.ID = pod.ID
|
pod.DesiredState.Manifest.ID = pod.ID
|
||||||
|
|
||||||
return apiserver.MakeAsync(func() (interface{}, error) {
|
return apiserver.MakeAsync(func() (interface{}, error) {
|
||||||
// TODO(lavalamp): Separate scheduler more cleanly.
|
err := storage.scheduleAndCreatePod(pod)
|
||||||
machine, err := storage.scheduler.Schedule(pod, storage.minionLister)
|
|
||||||
if err != nil {
|
|
||||||
return nil, err
|
|
||||||
}
|
|
||||||
err = storage.registry.CreatePod(machine, pod)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user