github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test that controller descriptors should not be feature gated

Browse Source 
controllers enabled by default should define feature gates in
ControllerDescriptor.requiredFeatureGates and not during a descriptor
registration in NewControllerDescriptors
This commit is contained in:
Filip Křepinský
2023-10-30 14:35:02 +01:00
parent fed11c0793
commit 1daf1b0705
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/kube-controller-manager/app/controllermanager_test.go
View File

@@ -107,6 +107,9 @@ func TestNewControllerDescriptorsShouldNotPanic(t *testing.T) {
} }
func TestNewControllerDescriptorsAlwaysReturnsDescriptorsForAllControllers(t *testing.T) { func TestNewControllerDescriptorsAlwaysReturnsDescriptorsForAllControllers(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, "AllAlpha", false)()
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, "AllBeta", false)()
controllersWithoutFeatureGates := KnownControllers() controllersWithoutFeatureGates := KnownControllers()
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, "AllAlpha", true)() defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, "AllAlpha", true)()