kublet/userns: Switch TestGetOrCreateUserNamespaceMappingsDisabled to table format
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
This commit is contained in:
		 Rodrigo Campos
					Rodrigo Campos
				
			
				
					committed by
					
						 Giuseppe Scrivano
						Giuseppe Scrivano
					
				
			
			
				
	
			
			
			 Giuseppe Scrivano
						Giuseppe Scrivano
					
				
			
						parent
						
							b2a92406ef
						
					
				
				
					commit
					1fb1218f57
				
			| @@ -21,6 +21,7 @@ import ( | |||||||
|  |  | ||||||
| 	"github.com/stretchr/testify/assert" | 	"github.com/stretchr/testify/assert" | ||||||
| 	"github.com/stretchr/testify/require" | 	"github.com/stretchr/testify/require" | ||||||
|  | 	v1 "k8s.io/api/core/v1" | ||||||
| 	utilfeature "k8s.io/apiserver/pkg/util/feature" | 	utilfeature "k8s.io/apiserver/pkg/util/feature" | ||||||
| 	featuregatetesting "k8s.io/component-base/featuregate/testing" | 	featuregatetesting "k8s.io/component-base/featuregate/testing" | ||||||
| 	pkgfeatures "k8s.io/kubernetes/pkg/features" | 	pkgfeatures "k8s.io/kubernetes/pkg/features" | ||||||
| @@ -48,14 +49,33 @@ func TestReleaseDisabled(t *testing.T) { | |||||||
|  |  | ||||||
| func TestGetOrCreateUserNamespaceMappingsDisabled(t *testing.T) { | func TestGetOrCreateUserNamespaceMappingsDisabled(t *testing.T) { | ||||||
| 	defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, pkgfeatures.UserNamespacesSupport, false)() | 	defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, pkgfeatures.UserNamespacesSupport, false)() | ||||||
|  | 	tests := []struct { | ||||||
|  | 		name    string | ||||||
|  | 		pod     *v1.Pod | ||||||
|  | 		success bool | ||||||
|  | 	}{ | ||||||
|  | 		{ | ||||||
|  | 			name:    "pod is nil", | ||||||
|  | 			pod:     nil, | ||||||
|  | 			success: true, | ||||||
|  | 		}, | ||||||
|  | 	} | ||||||
|  |  | ||||||
| 	testUserNsPodsManager := &testUserNsPodsManager{} | 	for _, test := range tests { | ||||||
| 	m, err := MakeUserNsManager(testUserNsPodsManager) | 		t.Run(test.name, func(t *testing.T) { | ||||||
| 	require.NoError(t, err) | 			testUserNsPodsManager := &testUserNsPodsManager{} | ||||||
|  | 			m, err := MakeUserNsManager(testUserNsPodsManager) | ||||||
|  | 			require.NoError(t, err) | ||||||
|  |  | ||||||
| 	userns, err := m.GetOrCreateUserNamespaceMappings(nil, "") | 			userns, err := m.GetOrCreateUserNamespaceMappings(test.pod, "") | ||||||
| 	assert.NoError(t, err) | 			assert.Nil(t, userns) | ||||||
| 	assert.Nil(t, userns) | 			if test.success { | ||||||
|  | 				assert.NoError(t, err) | ||||||
|  | 			} else { | ||||||
|  | 				assert.Error(t, err) | ||||||
|  | 			} | ||||||
|  | 		}) | ||||||
|  | 	} | ||||||
| } | } | ||||||
|  |  | ||||||
| func TestCleanupOrphanedPodUsernsAllocationsDisabled(t *testing.T) { | func TestCleanupOrphanedPodUsernsAllocationsDisabled(t *testing.T) { | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user