github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reword modifications for clarity

Browse Source
This commit is contained in:
matte21
2019-12-31 09:48:28 +01:00
parent 3ae8c864de
commit 21f59c9923
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
staging/src/k8s.io/client-go/tools/cache/shared_informer.go vendored
View File

@@ -107,17 +107,15 @@ import (
// For a given SharedInformer and client, the notifications are // For a given SharedInformer and client, the notifications are
// delivered sequentially. For a given SharedInformer, client, and // delivered sequentially. For a given SharedInformer, client, and
// object ID, the notifications are delivered in order. Because // object ID, the notifications are delivered in order. Because
// `ObjectMeta.UID` has no role in identifying objects, if an object // `ObjectMeta.UID` has no role in identifying objects, it is possible
// O1 with ID (e.g. namespace and name) X and `ObjectMeta.UID` U1 in // that when (1) object O1 with ID (e.g. namespace and name) X and
// the SharedInformer's local cache is deleted and shortly after // `ObjectMeta.UID` U1 in the SharedInformer's local cache is deleted
// another relevant object O2 with ID X and `ObjectMeta.UID` U2 is // and later (2) another object O2 with ID X and ObjectMeta.UID U2 is
// created a client has no guarantee of seeing O1's deletion and // created the informer's clients are not notified of (1) and (2) but
// O2's creation as two separate notifications, it might as well // rather are notified only of an update from O1 to O2. Clients that
// receive a single update notification where the old object is O1 // need to detect such cases might do so by comparing the `ObjectMeta.UID`
// and the new object is O2. Clients that need to detect such cases // field of the old and the new object in the code that handles update
// might do so by comparing the `ObjectMeta.UID` field of the old // notifications (i.e. `OnUpdate` method of ResourceEventHandler).
// and the new object in the code that handles update notifications
// (i.e. `OnUpdate` method of ResourceEventHandler).
// //
// A client must process each notification promptly; a SharedInformer // A client must process each notification promptly; a SharedInformer
// is not engineered to deal well with a large backlog of // is not engineered to deal well with a large backlog of