From 23a90a7679512b1c0bdffee27165c1414eb3383c Mon Sep 17 00:00:00 2001 From: FengyunPan Date: Thu, 29 Jun 2017 17:22:03 +0800 Subject: [PATCH] Fix removing finalizer for garbage collector The loop should use 'continue' not 'break', otherwise removeFinalizer() not only removes "orphaningFinalizer" from its finalizers list but also removes others. --- pkg/controller/garbagecollector/operations.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/garbagecollector/operations.go b/pkg/controller/garbagecollector/operations.go index b488fb8d1a2..fcfdcd1cee6 100644 --- a/pkg/controller/garbagecollector/operations.go +++ b/pkg/controller/garbagecollector/operations.go @@ -115,7 +115,7 @@ func (gc *GarbageCollector) removeFinalizer(owner *node, targetFinalizer string) for _, f := range finalizers { if f == targetFinalizer { found = true - break + continue } newFinalizers = append(newFinalizers, f) }