From 53e3bff4641cce88f58a901759381d4229c634b3 Mon Sep 17 00:00:00 2001 From: Brendan Burns Date: Thu, 4 Sep 2014 09:54:50 -0700 Subject: [PATCH 1/3] Re-enable travis for Go tip --- .travis.yml | 1 + hack/test-go.sh | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/.travis.yml b/.travis.yml index f19e60aecc2..b34148365f3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,6 +1,7 @@ language: go go: + - tip - 1.3 - 1.2 diff --git a/hack/test-go.sh b/hack/test-go.sh index 463627fa5cd..3e908c3ed53 100755 --- a/hack/test-go.sh +++ b/hack/test-go.sh @@ -40,6 +40,11 @@ find_test_dirs() { \) -name '*_test.go' -print0 | xargs -0n1 dirname | sort -u | xargs -n1 printf "${KUBE_GO_PACKAGE}/%s\n" } +# there is currently a race in the coverage code in tip. Remove this when it is fixed +# see https://code.google.com/p/go/issues/detail?id=8630 for details. +if [[ ${TRAVIS_GO_VERSION} eq "tip" ]]; then + KUBE_COVER="" +fi # -covermode=atomic becomes default with -race in Go >=1.3 KUBE_COVER=${KUBE_COVER:--cover -covermode=atomic} KUBE_TIMEOUT=${KUBE_TIMEOUT:--timeout 30s} From 78df593c57bd5e8bc2ab649c60e63c3da70580e1 Mon Sep 17 00:00:00 2001 From: Brendan Burns Date: Thu, 4 Sep 2014 10:03:49 -0700 Subject: [PATCH 2/3] Fix a shell typo. --- hack/test-go.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hack/test-go.sh b/hack/test-go.sh index 303b80c8a1e..9be038abbab 100755 --- a/hack/test-go.sh +++ b/hack/test-go.sh @@ -46,7 +46,7 @@ find_test_pkgs() { # there is currently a race in the coverage code in tip. Remove this when it is fixed # see https://code.google.com/p/go/issues/detail?id=8630 for details. -if [[ ${TRAVIS_GO_VERSION} eq "tip" ]]; then +if [[ "${TRAVIS_GO_VERSION}" -eq "tip" ]]; then KUBE_COVER="" fi # -covermode=atomic becomes default with -race in Go >=1.3 From 3864cf453a94e35e8459f9a4a9644537712681c4 Mon Sep 17 00:00:00 2001 From: Brendan Burns Date: Thu, 4 Sep 2014 10:30:31 -0700 Subject: [PATCH 3/3] Fix travis and cluster installs. --- .travis.yml | 4 ++-- cluster/saltbase/salt/etcd/init.sls | 1 + hack/install-etcd.sh | 21 +++++++++++++++++++++ 3 files changed, 24 insertions(+), 2 deletions(-) create mode 100755 hack/install-etcd.sh diff --git a/.travis.yml b/.travis.yml index b34148365f3..73f17bf8db8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,7 +7,7 @@ go: install: - go get code.google.com/p/go.tools/cmd/cover - - go get github.com/coreos/etcd + - ./hack/install-etcd.sh - ./hack/verify-gofmt.sh - ./hack/verify-boilerplate.sh - ./hack/install-std-race.sh @@ -16,7 +16,7 @@ install: script: - ./hack/test-go.sh - PATH=$HOME/gopath/bin:$PATH ./hack/test-cmd.sh - - PATH=$HOME/gopath/bin:$PATH ./hack/test-integration.sh + - PATH=$HOME/gopath/bin:$HOME/etcd/bin:$PATH ./hack/test-integration.sh notifications: irc: "chat.freenode.net#google-containers" diff --git a/cluster/saltbase/salt/etcd/init.sls b/cluster/saltbase/salt/etcd/init.sls index 4e8f33e79df..783a88ecda2 100644 --- a/cluster/saltbase/salt/etcd/init.sls +++ b/cluster/saltbase/salt/etcd/init.sls @@ -5,6 +5,7 @@ etcd-install: cmd.wait: - cwd: /var/src/etcd - names: + - git checkout ab4bcc18694644d12f0c038339d8d039072502b1 - ./build - env: - PATH: {{ grains['path'] }}:/usr/local/bin diff --git a/hack/install-etcd.sh b/hack/install-etcd.sh new file mode 100755 index 00000000000..b9017c24190 --- /dev/null +++ b/hack/install-etcd.sh @@ -0,0 +1,21 @@ +#!/bin/bash + +# Copyright 2014 Google Inc. All rights reserved. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +git clone https://github.com/coreos/etcd.git +cd etcd +git checkout ab4bcc18694644d12f0c038339d8d039072502b1 +./build +