github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #108680 from kidlj/fix_cache_index_comments

Browse Source 
make comments of `(c *threadSafeMap) updateIndices` optimization code more accurate
This commit is contained in:
Kubernetes Prow Robot
2022-03-21 20:19:44 -07:00
committed by GitHub
parent 7cf5c02980 0eae1f3add
commit 29528a266a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/client-go/tools/cache/thread_safe_store.go vendored
View File

@@ -281,14 +281,14 @@ func (c *threadSafeMap) updateIndices(oldObj interface{}, newObj interface{}, ke
} }
for _, value := range oldIndexValues { for _, value := range oldIndexValues {
// We optimize for the most common case where index returns a single value. // We optimize for the most common case where indexFunc returns a single value.
if len(indexValues) == 1 && value == indexValues[0] { if len(indexValues) == 1 && value == indexValues[0] {
continue continue
} }
c.deleteKeyFromIndex(key, value, index) c.deleteKeyFromIndex(key, value, index)
} }
for _, value := range indexValues { for _, value := range indexValues {
// We optimize for the most common case where index returns a single value. // We optimize for the most common case where indexFunc returns a single value.
if len(oldIndexValues) == 1 && value == oldIndexValues[0] { if len(oldIndexValues) == 1 && value == oldIndexValues[0] {
continue continue
} }