From 29a870da2e6e68b4716b942b5441a79c3473a9dc Mon Sep 17 00:00:00 2001 From: Dave Chen Date: Wed, 26 Jan 2022 17:45:57 +0800 Subject: [PATCH] kubeadm: warn only when config value is different with default value Compare with two pointers will always show that they are different value, so it will always print the warning message. Signed-off-by: Dave Chen --- cmd/kubeadm/app/componentconfigs/kubelet.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/kubeadm/app/componentconfigs/kubelet.go b/cmd/kubeadm/app/componentconfigs/kubelet.go index 31b2e94a15b..65b2d08ce42 100644 --- a/cmd/kubeadm/app/componentconfigs/kubelet.go +++ b/cmd/kubeadm/app/componentconfigs/kubelet.go @@ -223,7 +223,7 @@ func (kc *kubeletConfig) Default(cfg *kubeadmapi.ClusterConfiguration, _ *kubead if kc.config.ResolverConfig == nil { kc.config.ResolverConfig = utilpointer.String(kubeletSystemdResolverConfig) } else { - if kc.config.ResolverConfig != utilpointer.String(kubeletSystemdResolverConfig) { + if *kc.config.ResolverConfig != kubeletSystemdResolverConfig { warnDefaultComponentConfigValue(kind, "resolvConf", kubeletSystemdResolverConfig, *kc.config.ResolverConfig) } }