github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #125756 from p0lyn0mial/upstream-improve-run-test-list

Browse Source 
apiserver/storage: storagetesting.RunTestList validates RemainingItemCount
This commit is contained in:
Kubernetes Prow Robot
2024-06-27 05:25:16 -07:00
committed by GitHub
parent 95c7621ed0 f9b15700fb
commit 29defc15aa
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/apiserver/pkg/storage/testing/store_tests.go
View File

@@ -28,6 +28,7 @@ import (
"sync" "sync"
"testing" "testing"
"github.com/google/go-cmp/cmp"
apierrors "k8s.io/apimachinery/pkg/api/errors" apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/fields" "k8s.io/apimachinery/pkg/fields"
@@ -1246,6 +1247,9 @@ func RunTestList(ctx context.Context, t *testing.T, store storage.Interface, com
} else { } else {
ExpectContains(t, "incorrect list pods", toInterfaceSlice(tt.expectedAlternatives), out.Items) ExpectContains(t, "incorrect list pods", toInterfaceSlice(tt.expectedAlternatives), out.Items)
} }
if !cmp.Equal(tt.expectedRemainingItemCount, out.RemainingItemCount) {
t.Fatalf("unexpected remainingItemCount, diff: %s", cmp.Diff(tt.expectedRemainingItemCount, out.RemainingItemCount))
}
}) })
} }
} }