github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #126344 from MikeSpreitzer/fix-120112

Browse Source 
Relax noise margin in TestOneWeightedHistogram
This commit is contained in:
Kubernetes Prow Robot
2024-07-27 14:13:50 -07:00
committed by GitHub
parent ba6141a145 77541c1e35
commit 2aa468c708
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
staging/src/k8s.io/component-base/metrics/prometheusextension/weighted_histogram_test.go
View File

@@ -99,7 +99,7 @@ func exerciseWeightedHistograms(t *testing.T, whSpecs ...weightedHistogramSpecFu
for _, term := range terms { for _, term := range terms {
ee.sum += term ee.sum += term
} }
t.Logf("Adding expectation %#+v", ee) t.Logf("At idx=%v, adding expectation of buckets=%#+v, upperBounds=%#+v, sum=%v, count=%v", whIdx, ee.buckets, ee.upperBounds, ee.sum, ee.count)
expectations = append(expectations, ee) expectations = append(expectations, ee)
} }
// Do the planned calls on ObserveWithWeight, in randomized order // Do the planned calls on ObserveWithWeight, in randomized order
@@ -142,8 +142,10 @@ func exerciseWeightedHistograms(t *testing.T, whSpecs ...weightedHistogramSpecFu
actualSum := actualHist.GetSampleSum() actualSum := actualHist.GetSampleSum()
num := math.Abs(actualSum - ee.sum) num := math.Abs(actualSum - ee.sum)
den := math.Max(math.Abs(actualSum), math.Abs(ee.sum)) den := math.Max(math.Abs(actualSum), math.Abs(ee.sum))
if num > den/1e14 { relErr := num / den
t.Errorf("At idx=%d, expected sum %v but got %v, err=%v", idx, ee.sum, actualSum, actualSum-ee.sum) // Issue 120112 reports relative errors as high as 9.55994394104272e-14
if relErr > 1e-13 {
t.Errorf("At idx=%d, expected sum %v but got %v, err=%v, relativeErr=%v", idx, ee.sum, actualSum, actualSum-ee.sum, relErr)
} }
} }
} }