github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pkg/proxy: fix stale detection logic

Browse Source 
Signed-off-by: Daman Arora <aroradaman@gmail.com>
This commit is contained in:
Daman Arora
2023-08-27 19:05:13 +05:30
parent 01df59a73b
commit 2e5f17166b
3 changed files with 86 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
pkg/proxy/endpoints.go
View File

@@ -407,20 +407,18 @@ func detectStaleConntrackEntries(oldEndpointsMap, newEndpointsMap EndpointsMap,
}
for _, ep := range epList {
// If the old endpoint wasn't Ready then there can't be stale
// If the old endpoint wasn't Serving then there can't be stale
// conntrack entries since there was no traffic sent to it.
if !ep.IsReady() {
if !ep.IsServing() {
continue
}
deleted := true
// Check if the endpoint has changed, including if it went from
// ready to not ready. If it did change stale entries for the old
// serving to not serving. If it did change stale entries for the old
// endpoint have to be cleared.
for i := range newEndpointsMap[svcPortName] {
if newEndpointsMap[svcPortName][i].String() == ep.String() &&
newEndpointsMap[svcPortName][i].IsReady() == ep.IsReady() &&
newEndpointsMap[svcPortName][i].GetIsLocal() == ep.GetIsLocal() {
if newEndpointsMap[svcPortName][i].String() == ep.String() {
deleted = false
break
}
@@ -441,21 +439,21 @@ func detectStaleConntrackEntries(oldEndpointsMap, newEndpointsMap EndpointsMap,
continue
}
epReady := 0
epServing := 0
for _, ep := range epList {
if ep.IsReady() {
epReady++
if ep.IsServing() {
epServing++
}
}
oldEpReady := 0
oldEpServing := 0
for _, ep := range oldEndpointsMap[svcPortName] {
if ep.IsReady() {
oldEpReady++
if ep.IsServing() {
oldEpServing++
}
}
if epReady > 0 && oldEpReady == 0 {
if epServing > 0 && oldEpServing == 0 {
*newlyActiveUDPServices = append(*newlyActiveUDPServices, svcPortName)
}
}