github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #116482 from smarterclayton/no_mutate

Browse Source 
kubelet: Do not mutate pods in the pod manager
This commit is contained in:
Kubernetes Prow Robot
2023-04-12 02:22:32 -07:00
committed by GitHub
parent 5f23f83587 aadb87bdcd
commit 2f1db33dd5
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/kubelet/kubelet_getters.go
View File

@@ -181,11 +181,14 @@ func (kl *Kubelet) GetPods() []*v1.Pod {
pods := kl.podManager.GetPods() pods := kl.podManager.GetPods()
// a kubelet running without apiserver requires an additional // a kubelet running without apiserver requires an additional
// update of the static pod status. See #57106 // update of the static pod status. See #57106
for _, p := range pods { for i, p := range pods {
if kubelettypes.IsStaticPod(p) { if kubelettypes.IsStaticPod(p) {
if status, ok := kl.statusManager.GetPodStatus(p.UID); ok { if status, ok := kl.statusManager.GetPodStatus(p.UID); ok {
klog.V(2).InfoS("Pod status updated", "pod", klog.KObj(p), "status", status.Phase) klog.V(2).InfoS("Pod status updated", "pod", klog.KObj(p), "status", status.Phase)
// do not mutate the cache
p = p.DeepCopy()
p.Status = status p.Status = status
pods[i] = p
} }
} }
} }