github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #114412 from thockin/api_warn_workloads_name_not_dnslabel

Browse Source 
Issue API warnings when workload names are not DNS labels
This commit is contained in:
Kubernetes Prow Robot
2022-12-16 18:07:41 -08:00
committed by GitHub
parent a93eda9db3 8f62b94991
commit 2f2021e208
8 changed files with 95 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
pkg/apis/core/validation/validation_test.go
View File

@@ -3230,11 +3230,23 @@ func TestValidateVolumes(t *testing.T) {
}},
},
{
name: "name not a DNS label",
name: "name has dots",
vol: core.Volume{
Name: "a.b.c",
VolumeSource: core.VolumeSource{EmptyDir: &core.EmptyDirVolumeSource{}},
},
errs: []verr{{
etype: field.ErrorTypeInvalid,
field: "name",
detail: "must not contain dots",
}},
},
{
name: "name not a DNS label",
vol: core.Volume{
Name: "Not a DNS label!",
VolumeSource: core.VolumeSource{EmptyDir: &core.EmptyDirVolumeSource{}},
},
errs: []verr{{
etype: field.ErrorTypeInvalid,
field: "name",
@@ -5042,13 +5054,13 @@ func TestValidateVolumes(t *testing.T) {
for i, err := range errs {
expErr := tc.errs[i]
if err.Type != expErr.etype {
t.Errorf("unexpected error type: got %v, want %v", expErr.etype, err.Type)
t.Errorf("unexpected error type:\n\twant: %q\n\t got: %q", expErr.etype, err.Type)
}
if !strings.HasSuffix(err.Field, "."+expErr.field) {
t.Errorf("unexpected error field: got %v, want %v", expErr.field, err.Field)
t.Errorf("unexpected error field:\n\twant: %q\n\t got: %q", expErr.field, err.Field)
}
if !strings.Contains(err.Detail, expErr.detail) {
t.Errorf("unexpected error detail: got %v, want %v", expErr.detail, err.Detail)
t.Errorf("unexpected error detail:\n\twant: %q\n\t got: %q", expErr.detail, err.Detail)
}
}
})