From 2f852a27cbd4eeebc7b3404a6e1550cff2d783cb Mon Sep 17 00:00:00 2001 From: kanwar saad bin liaqat Date: Wed, 13 Mar 2019 22:23:02 +0200 Subject: [PATCH] Fix double error of secret negative testcase E2E Test "Secret should fail to create secret in volume due to empty secret key" tries to create a secret with empty key and check whether it fails or not. But the secret creation in this test fails with double error due to invalid secret name. This will make this test to pass even if the fuctionality which needs to be tested is broken. This commit fix the secret name error(name should not have capital letters) so that the secret creation fails only due to desired reason. Signed-off-by: kanwar saad bin liaqat --- test/e2e/common/secrets.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/common/secrets.go b/test/e2e/common/secrets.go index ce771c22ebd..b8cd22d0dc2 100644 --- a/test/e2e/common/secrets.go +++ b/test/e2e/common/secrets.go @@ -147,7 +147,7 @@ func newEnvFromSecret(namespace, name string) *v1.Secret { } func createEmptyKeySecretForTest(f *framework.Framework) (*v1.Secret, error) { - secretName := "secret-emptyKey-test-" + string(uuid.NewUUID()) + secretName := "secret-emptykey-test-" + string(uuid.NewUUID()) secret := &v1.Secret{ ObjectMeta: metav1.ObjectMeta{ Namespace: f.Namespace.Name,