github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

change func WithTracing parameter naming

Browse Source 
Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
This commit is contained in:
KubeKyrie
2023-12-04 23:33:46 +08:00
parent 55f2bc1043
commit 2fd4758359
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/component-base/tracing/utils.go
View File

@@ -91,7 +91,7 @@ func NewProvider(ctx context.Context,
} }
// WithTracing adds tracing to requests if the incoming request is sampled // WithTracing adds tracing to requests if the incoming request is sampled
func WithTracing(handler http.Handler, tp oteltrace.TracerProvider, serviceName string) http.Handler { func WithTracing(handler http.Handler, tp oteltrace.TracerProvider, spanName string) http.Handler {
opts := []otelhttp.Option{ opts := []otelhttp.Option{
otelhttp.WithPropagators(Propagators()), otelhttp.WithPropagators(Propagators()),
otelhttp.WithTracerProvider(tp), otelhttp.WithTracerProvider(tp),
@@ -106,7 +106,7 @@ func WithTracing(handler http.Handler, tp oteltrace.TracerProvider, serviceName
}) })
// With Noop TracerProvider, the otelhttp still handles context propagation. // With Noop TracerProvider, the otelhttp still handles context propagation.
// See https://github.com/open-telemetry/opentelemetry-go/tree/main/example/passthrough // See https://github.com/open-telemetry/opentelemetry-go/tree/main/example/passthrough
return otelhttp.NewHandler(wrappedHandler, serviceName, opts...) return otelhttp.NewHandler(wrappedHandler, spanName, opts...)
} }
// WrapperFor can be used to add tracing to a *rest.Config. // WrapperFor can be used to add tracing to a *rest.Config.