github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #108976 from ArangoGutierrez/devel/typos/scheduler

Browse Source 
Fix typos under pkg/scheduler
This commit is contained in:
Kubernetes Prow Robot
2022-03-25 15:35:09 -07:00
committed by GitHub
parent 9472cbb547 d2f67b42b7
commit 317f8afe92
7 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/scheduler/framework/plugins/noderesources/most_allocated_test.go
View File

@@ -224,8 +224,8 @@ func TestMostAllocatedScoringStrategy(t *testing.T) {
resources: defaultResources,
},
{
// resource with negtive weight is not allowed
name: "resource with negtive weight",
// resource with negative weight is not allowed
name: "resource with negative weight",
requestedPod: st.MakePod().
Req(map[v1.ResourceName]string{"cpu": "1000", "memory": "2000"}).
Req(map[v1.ResourceName]string{"cpu": "2000", "memory": "3000"}).

2
pkg/scheduler/framework/plugins/volumebinding/binder.go
View File

@@ -390,7 +390,7 @@ func (b *volumeBinder) AssumePodVolumes(assumedPod *v1.Pod, nodeName string, pod
b.revertAssumedPVs(newBindings)
return false, err
}
// TODO: can we assume everytime?
// TODO: can we assume every time?
if dirty {
err = b.pvCache.Assume(newPV)
if err != nil {

2
pkg/scheduler/framework/preemption/preemption_test.go
View File

@@ -64,7 +64,7 @@ type FakePostFilterPlugin struct {
func (pl *FakePostFilterPlugin) SelectVictimsOnNode(
ctx context.Context, state *framework.CycleState, pod *v1.Pod,
nodeInfo *framework.NodeInfo, pdbs []*policy.PodDisruptionBudget) (victims []*v1.Pod, numViolatingVictim int, staus *framework.Status) {
nodeInfo *framework.NodeInfo, pdbs []*policy.PodDisruptionBudget) (victims []*v1.Pod, numViolatingVictim int, status *framework.Status) {
return append(victims, nodeInfo.Pods[0].Pod), pl.numViolatingVictim, nil
}

2
pkg/scheduler/framework/runtime/framework_test.go
View File

@@ -1286,7 +1286,7 @@ func TestFilterPlugins(t *testing.T) {
"TestPlugin": framework.NewStatus(framework.UnschedulableAndUnresolvable, "injected filter status").WithFailedPlugin("TestPlugin"),
},
},
// followings tests cover multiple-plugins scenarios
// following tests cover multiple-plugins scenarios
{
name: "ErrorAndErrorFilters",
plugins: []*TestPlugin{

2
pkg/scheduler/internal/cache/cache_test.go vendored
View File

@@ -929,7 +929,7 @@ func buildNodeInfo(node *v1.Node, pods []*v1.Pod) *framework.NodeInfo {
// TestNodeOperators tests node operations of cache, including add, update
// and remove.
func TestNodeOperators(t *testing.T) {
// Test datas
// Test data
nodeName := "test-node"
cpu1 := resource.MustParse("1000m")
mem100m := resource.MustParse("100m")

2
pkg/scheduler/internal/cache/node_tree_test.go vendored
View File

@@ -468,7 +468,7 @@ func TestNodeTreeMultiOperations(t *testing.T) {
removeIndex++
}
default:
t.Errorf("unknow operation: %v", op)
t.Errorf("unknown operation: %v", op)
}
}
output, err := nt.list()

4
pkg/scheduler/internal/queue/scheduling_queue_test.go
View File

@@ -439,7 +439,7 @@ func TestPriorityQueue_Activate(t *testing.T) {
name: "pod already in activeQ",
qPodInfoInActiveQ: []*framework.QueuedPodInfo{{PodInfo: highPriNominatedPodInfo}},
qPodInfoToActivate: &framework.QueuedPodInfo{PodInfo: highPriNominatedPodInfo},
want: []*framework.QueuedPodInfo{{PodInfo: highPriNominatedPodInfo}}, // 1 already actived
want: []*framework.QueuedPodInfo{{PodInfo: highPriNominatedPodInfo}}, // 1 already active
},
{
name: "pod not in unschedulablePods/podBackoffQ",
@@ -2206,7 +2206,7 @@ func TestMoveAllToActiveOrBackoffQueue_PreEnqueueChecks(t *testing.T) {
}
queuedPodInfo, ok := obj.(*framework.QueuedPodInfo)
if !ok {
t.Fatalf("Fail to covert popped obj (type %T) to *framework.QueuedPodInfo", obj)
t.Fatalf("Fail to convert popped obj (type %T) to *framework.QueuedPodInfo", obj)
}
got = append(got, queuedPodInfo.Pod.Name)
}