Use utils.net to parse ports instead of atoi (#89120)

This commit is contained in:
Jie Shen
2020-04-22 11:55:52 +08:00
committed by GitHub
parent 85ee5fdd90
commit 363bb39142
10 changed files with 20 additions and 12 deletions

View File

@@ -14,6 +14,7 @@ go_library(
"//staging/src/k8s.io/apimachinery/pkg/util/net:go_default_library",
"//vendor/github.com/spf13/pflag:go_default_library",
"//vendor/k8s.io/klog:go_default_library",
"//vendor/k8s.io/utils/net:go_default_library",
],
)

View File

@@ -19,12 +19,12 @@ package flag
import (
"fmt"
"net"
"strconv"
"github.com/spf13/pflag"
"k8s.io/klog"
utilnet "k8s.io/apimachinery/pkg/util/net"
utilsnet "k8s.io/utils/net"
)
// PrintFlags logs the flags in the flagset
@@ -109,7 +109,7 @@ func (v IPPortVar) Set(s string) error {
if net.ParseIP(host) == nil {
return fmt.Errorf("%q is not a valid IP address", host)
}
if _, err := strconv.Atoi(port); err != nil {
if _, err := utilsnet.ParsePort(port, true); err != nil {
return fmt.Errorf("%q is not a valid number", port)
}
*v.Val = s