Merge pull request #47014 from boingram/deletePod-handler-shouldnt-set-owner-refs
Automatic merge from submit-queue deletePod handler in the deployment controller shouldn't set owner refs **What this PR does / why we need it**: This PR stops the deletePod handler in the deployment controller from adopting replica sets when determining if a deployment needs to be requeued. It leaves this logic to the replication loop, removing the replica set adoption side effect. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #46933 **Special notes for your reviewer**: @kargakis PR for delete pod handler setting owner refs issue **Release note**: ```release-note ```
This commit is contained in:
@@ -356,7 +356,7 @@ func (dc *DeploymentController) deletePod(obj interface{}) {
|
||||
glog.V(4).Infof("Pod %s deleted.", pod.Name)
|
||||
if d := dc.getDeploymentForPod(pod); d != nil && d.Spec.Strategy.Type == extensions.RecreateDeploymentStrategyType {
|
||||
// Sync if this Deployment now has no more Pods.
|
||||
rsList, err := dc.getReplicaSetsForDeployment(d)
|
||||
rsList, err := util.ListReplicaSets(d, util.RsListFromClient(dc.client))
|
||||
if err != nil {
|
||||
return
|
||||
}
|
||||
|
Reference in New Issue
Block a user