Use const instead of hard code for volume plugin
This commit is contained in:
@@ -24,6 +24,8 @@ import (
|
||||
"k8s.io/apimachinery/pkg/types"
|
||||
)
|
||||
|
||||
const testPluginName = "kubernetes.io/testPlugin"
|
||||
|
||||
func TestSpecSourceConverters(t *testing.T) {
|
||||
v := &v1.Volume{
|
||||
Name: "foo",
|
||||
@@ -62,7 +64,7 @@ func (plugin *testPlugins) Init(host VolumeHost) error {
|
||||
}
|
||||
|
||||
func (plugin *testPlugins) GetPluginName() string {
|
||||
return "testPlugin"
|
||||
return testPluginName
|
||||
}
|
||||
|
||||
func (plugin *testPlugins) GetVolumeName(spec *Spec) (string, error) {
|
||||
@@ -106,11 +108,11 @@ func TestVolumePluginMgrFunc(t *testing.T) {
|
||||
var prober DynamicPluginProber = nil // TODO (#51147) inject mock
|
||||
vpm.InitPlugins(newTestPlugin(), prober, nil)
|
||||
|
||||
plug, err := vpm.FindPluginByName("testPlugin")
|
||||
plug, err := vpm.FindPluginByName(testPluginName)
|
||||
if err != nil {
|
||||
t.Errorf("Can't find the plugin by name")
|
||||
}
|
||||
if plug.GetPluginName() != "testPlugin" {
|
||||
if plug.GetPluginName() != testPluginName {
|
||||
t.Errorf("Wrong name: %s", plug.GetPluginName())
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user