From 8f55ac9651bac2fa5cbb40fb191f21f09163a03d Mon Sep 17 00:00:00 2001 From: Filipe Brandenburger Date: Wed, 27 Aug 2014 13:26:40 -0700 Subject: [PATCH] Do not set IFS to the wrong value The correct way to reset it to the default would be IFS=$' \t\n', but there's no reason to assume a wrong setting here, in fact, nothing this script does should depend on an IFS setting, so let's just drop this line altogether. Tested: - Ran "release/build-release.sh " before and after this change. Compared the two trees for differences, only difference was the SHA1 in output/release/master-release/src/saltbase/pillar/common.sls $ diff -Naur output.orig/release/master-release/ output/release/master-release/ diff -Naur output.orig/release/master-release/src/saltbase/pillar/common.sls output/release/master-release/src/saltbase/pillar/common.sls --- output.orig/release/master-release/src/saltbase/pillar/common.sls 2014-08-27 13:28:52.104241577 -0700 +++ output/release/master-release/src/saltbase/pillar/common.sls 2014-08-27 13:29:28.296087806 -0700 @@ -1,2 +1,2 @@ instance_prefix: MY_INSTANCE_NAME-minion -go_opt: -ldflags "-X github.com/GoogleCloudPlatform/kubernetes/pkg/version.commitFromGit 'e169da2abfbf'" +go_opt: -ldflags "-X github.com/GoogleCloudPlatform/kubernetes/pkg/version.commitFromGit '8aea0d85e447-dirty'" Signed-off-by: Filipe Brandenburger --- release/build-release.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/release/build-release.sh b/release/build-release.sh index a75e4c453d7..ca06c21e60a 100755 --- a/release/build-release.sh +++ b/release/build-release.sh @@ -19,7 +19,6 @@ # exit on any error set -eu set -o pipefail -IFS=$'\n\t' SCRIPT_DIR=$(CDPATH="" cd $(dirname $0); pwd)