From 3aabd7a9aec9a8733b2fa76fb9d0f0eef79ce49a Mon Sep 17 00:00:00 2001 From: Doug MacEachern Date: Tue, 30 Jan 2018 12:23:21 -0800 Subject: [PATCH] vclib: enable VM disk attach test Follow up to PR #58534 , where this test was disabled due to a limitation in govmomi/simulator. The test passes as expected with godeps update of govmomi. --- .../providers/vsphere/vclib/virtualmachine_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cloudprovider/providers/vsphere/vclib/virtualmachine_test.go b/pkg/cloudprovider/providers/vsphere/vclib/virtualmachine_test.go index c994621e76b..0b38fd1be4f 100644 --- a/pkg/cloudprovider/providers/vsphere/vclib/virtualmachine_test.go +++ b/pkg/cloudprovider/providers/vsphere/vclib/virtualmachine_test.go @@ -90,7 +90,7 @@ func TestVirtualMachine(t *testing.T) { options := &VolumeOptions{SCSIControllerType: PVSCSIControllerType} - for _, expect := range []bool{true} { // TODO: vcsim needs to honor FileOperation to attach an existing disk + for _, expect := range []bool{true, false} { attached, err := vm.IsDiskAttached(ctx, diskPath) if err != nil { t.Error(err)