Fixed spotty CanSupport for PV and added more unit tests for same
This commit is contained in:
@@ -53,7 +53,7 @@ func (plugin *RBDPlugin) Name() string {
|
||||
}
|
||||
|
||||
func (plugin *RBDPlugin) CanSupport(spec *volume.Spec) bool {
|
||||
if spec.VolumeSource.RBD == nil {
|
||||
if spec.VolumeSource.RBD == nil && spec.PersistentVolumeSource.RBD == nil {
|
||||
return false
|
||||
}
|
||||
// see if rbd is there
|
||||
|
@@ -37,6 +37,9 @@ func TestCanSupport(t *testing.T) {
|
||||
if plug.Name() != "kubernetes.io/rbd" {
|
||||
t.Errorf("Wrong name: %s", plug.Name())
|
||||
}
|
||||
if plug.CanSupport(&volume.Spec{Name: "foo", VolumeSource: api.VolumeSource{}}) {
|
||||
t.Errorf("Expected false")
|
||||
}
|
||||
}
|
||||
|
||||
type fakeDiskManager struct{}
|
||||
|
Reference in New Issue
Block a user