github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: disable SchedulerQueueingHints feature flag by default

Browse Source
This commit is contained in:
Kensei Nakada
2023-12-13 03:59:48 +00:00
parent 0c645922ed
commit 3b8f25dfdd
3 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/features/kube_features.go
View File

@@ -1176,7 +1176,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
ElasticIndexedJob: {Default: true, PreRelease: featuregate.Beta}, ElasticIndexedJob: {Default: true, PreRelease: featuregate.Beta},
SchedulerQueueingHints: {Default: true, PreRelease: featuregate.Beta}, SchedulerQueueingHints: {Default: false, PreRelease: featuregate.Beta},
SecurityContextDeny: {Default: false, PreRelease: featuregate.Alpha}, SecurityContextDeny: {Default: false, PreRelease: featuregate.Alpha},

2
pkg/scheduler/internal/queue/scheduling_queue_test.go
View File

@@ -1363,6 +1363,8 @@ func TestPriorityQueue_MoveAllToActiveOrBackoffQueue(t *testing.T) {
ctx, cancel := context.WithCancel(ctx) ctx, cancel := context.WithCancel(ctx)
defer cancel() defer cancel()
m := makeEmptyQueueingHintMapPerProfile() m := makeEmptyQueueingHintMapPerProfile()
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.SchedulerQueueingHints, true)()
m[""][NodeAdd] = []*QueueingHintFunction{ m[""][NodeAdd] = []*QueueingHintFunction{
{ {
PluginName: "fooPlugin", PluginName: "fooPlugin",

1
test/integration/scheduler/queue_test.go
View File

@@ -536,6 +536,7 @@ func (p *firstFailBindPlugin) Bind(ctx context.Context, state *framework.CycleSt
// TestRequeueByPermitRejection verify Pods failed by permit plugins in the binding cycle are // TestRequeueByPermitRejection verify Pods failed by permit plugins in the binding cycle are
// put back to the queue, according to the correct scheduling cycle number. // put back to the queue, according to the correct scheduling cycle number.
func TestRequeueByPermitRejection(t *testing.T) { func TestRequeueByPermitRejection(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.SchedulerQueueingHints, true)()
queueingHintCalledCounter := 0 queueingHintCalledCounter := 0
fakePermit := &fakePermitPlugin{} fakePermit := &fakePermitPlugin{}
registry := frameworkruntime.Registry{ registry := frameworkruntime.Registry{