Detect backsteps correctly in base path detection

Avoid false positives with atomic writer ..<timestamp> directories
This commit is contained in:
Jordan Liggitt
2018-03-13 00:59:40 -04:00
parent a7d6340ad2
commit 3fafdb7001
5 changed files with 20 additions and 16 deletions

View File

@@ -19,8 +19,6 @@ package util
import (
"fmt"
"net/url"
"path/filepath"
"strings"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
@@ -47,14 +45,3 @@ func parseEndpoint(endpoint string) (string, string, error) {
return u.Scheme, "", fmt.Errorf("protocol %q not supported", u.Scheme)
}
}
func pathWithinBase(fullPath, basePath string) bool {
rel, err := filepath.Rel(basePath, fullPath)
if err != nil {
return false
}
if strings.HasPrefix(rel, "..") {
return false
}
return true
}