From 4798d0bce274309c06121afdf61e6f253cfd4567 Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Mon, 1 Mar 2021 08:32:09 -0500 Subject: [PATCH] Avoid kubelet warnings for imagePullSecret entries with empty names --- pkg/kubelet/kubelet_pods.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/kubelet/kubelet_pods.go b/pkg/kubelet/kubelet_pods.go index e3494657b23..292f8a71b6e 100644 --- a/pkg/kubelet/kubelet_pods.go +++ b/pkg/kubelet/kubelet_pods.go @@ -881,6 +881,11 @@ func (kl *Kubelet) getPullSecretsForPod(pod *v1.Pod) []v1.Secret { pullSecrets := []v1.Secret{} for _, secretRef := range pod.Spec.ImagePullSecrets { + if len(secretRef.Name) == 0 { + // API validation permitted entries with empty names (http://issue.k8s.io/99454#issuecomment-787838112). + // Ignore to avoid unnecessary warnings. + continue + } secret, err := kl.secretManager.GetSecret(pod.Namespace, secretRef.Name) if err != nil { klog.Warningf("Unable to retrieve pull secret %s/%s for %s/%s due to %v. The image pull may not succeed.", pod.Namespace, secretRef.Name, pod.Namespace, pod.Name, err)