github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix use of docker removed ParseRepositoryTag() function

Browse Source 
Docker has removed the ParseRepositoryTag() function in
leading to failures using the kubernetes Go client API.

Lets use github.com/docker/distribution reference.ParseNamed()
instead.

Failure:

../k8s.io/kubernetes/pkg/util/parsers/parsers.go:30: undefined: parsers.ParseRepositoryTag
This commit is contained in:
Stef Walter
2016-03-30 16:23:07 +02:00
parent 04da473594
commit 481dbca8bc
7 changed files with 505 additions and 224 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/kubelet/dockertools/docker_test.go
View File

@@ -171,8 +171,10 @@ func TestParseImageName(t *testing.T) {
{"registry.example.com:5000/foobar:latest", "registry.example.com:5000/foobar", "latest"},
}
for _, test := range tests {
name, tag := parsers.ParseImageName(test.imageName)
if name != test.name || tag != test.tag {
name, tag, err := parsers.ParseImageName(test.imageName)
if err != nil {
t.Errorf("ParseImageName(%s) failed: %v", test.imageName, err)
} else if name != test.name || tag != test.tag {
t.Errorf("Expected name/tag: %s/%s, got %s/%s", test.name, test.tag, name, tag)
}
}