Make GetPrinter take the necessary conversion arguments

This fully encapsulates decisions about conversion within GetPrinter,
which prevents users from accidentally not converting.

pkg/kubectl/cmd/cmd_test.go

@@ -0,0 +1,117 @@
+/*
+Copyright 2014 Google Inc. All rights reserved.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package cmd_test
+
+import (
+	"bytes"
+	"fmt"
+	"io"
+	"io/ioutil"
+
+	"github.com/GoogleCloudPlatform/kubernetes/pkg/api/meta"
+	"github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl"
+	. "github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd"
+	"github.com/GoogleCloudPlatform/kubernetes/pkg/runtime"
+
+	"github.com/spf13/cobra"
+)
+
+type internalType struct {
+	Kind       string
+	APIVersion string
+
+	Name string
+}
+
+type externalType struct {
+	Kind       string `json:"kind"`
+	APIVersion string `json:"apiVersion"`
+
+	Name string `json:"name"`
+}
+
+func (*internalType) IsAnAPIObject() {}
+func (*externalType) IsAnAPIObject() {}
+
+func newExternalScheme() (*runtime.Scheme, meta.RESTMapper, runtime.Codec) {
+	scheme := runtime.NewScheme()
+	scheme.AddKnownTypeWithName("", "Type", &internalType{})
+	scheme.AddKnownTypeWithName("unlikelyversion", "Type", &externalType{})
+
+	codec := runtime.CodecFor(scheme, "unlikelyversion")
+	mapper := meta.NewDefaultRESTMapper([]string{"unlikelyversion"}, func(version string) (*meta.VersionInterfaces, bool) {
+		return &meta.VersionInterfaces{
+			Codec:            codec,
+			ObjectConvertor:  scheme,
+			MetadataAccessor: meta.NewAccessor(),
+		}, (version == "unlikelyversion")
+	})
+	mapper.Add(scheme, false, "unlikelyversion")
+
+	return scheme, mapper, codec
+}
+
+type testPrinter struct {
+	Obj runtime.Object
+	Err error
+}
+
+func (t *testPrinter) PrintObj(obj runtime.Object, out io.Writer) error {
+	t.Obj = obj
+	fmt.Fprintf(out, "%#v", obj)
+	return t.Err
+}
+
+type testDescriber struct {
+	Name, Namespace string
+	Output          string
+	Err             error
+}
+
+func (t *testDescriber) Describe(namespace, name string) (output string, err error) {
+	t.Namespace, t.Name = namespace, name
+	return t.Output, t.Err
+}
+
+type testFactory struct {
+	Client    kubectl.RESTClient
+	Describer kubectl.Describer
+	Printer   kubectl.ResourcePrinter
+	Err       error
+}
+
+func NewTestFactory() (*Factory, *testFactory, runtime.Codec) {
+	scheme, mapper, codec := newExternalScheme()
+	t := &testFactory{}
+	return &Factory{
+		Mapper: mapper,
+		Typer:  scheme,
+		Client: func(*cobra.Command, *meta.RESTMapping) (kubectl.RESTClient, error) {
+			return t.Client, t.Err
+		},
+		Describer: func(*cobra.Command, *meta.RESTMapping) (kubectl.Describer, error) {
+			return t.Describer, t.Err
+		},
+		Printer: func(cmd *cobra.Command, mapping *meta.RESTMapping, noHeaders bool) (kubectl.ResourcePrinter, error) {
+			return t.Printer, t.Err
+		},
+	}, t, codec
+}
+
+func objBody(codec runtime.Codec, obj runtime.Object) io.ReadCloser {
+	return ioutil.NopCloser(bytes.NewReader([]byte(runtime.EncodeOrDie(codec, obj))))
+}