replace repeated values with a constant
This commit is contained in:
		@@ -179,6 +179,8 @@ const (
 | 
				
			|||||||
	UpdateNodeTimeout = 2 * time.Minute
 | 
						UpdateNodeTimeout = 2 * time.Minute
 | 
				
			||||||
	// TLSBootstrapTimeout specifies how long kubeadm should wait for the kubelet to perform the TLS Bootstrap
 | 
						// TLSBootstrapTimeout specifies how long kubeadm should wait for the kubelet to perform the TLS Bootstrap
 | 
				
			||||||
	TLSBootstrapTimeout = 2 * time.Minute
 | 
						TLSBootstrapTimeout = 2 * time.Minute
 | 
				
			||||||
 | 
						// PrepullImagesInParallelTimeout specifies how long kubeadm should wait for prepulling images in parallel before timing out
 | 
				
			||||||
 | 
						PrepullImagesInParallelTimeout = 10 * time.Second
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	// DefaultControlPlaneTimeout specifies the default control plane (actually API Server) timeout for use by kubeadm
 | 
						// DefaultControlPlaneTimeout specifies the default control plane (actually API Server) timeout for use by kubeadm
 | 
				
			||||||
	DefaultControlPlaneTimeout = 4 * time.Minute
 | 
						DefaultControlPlaneTimeout = 4 * time.Minute
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -116,25 +116,25 @@ func TestPrepullImagesInParallel(t *testing.T) {
 | 
				
			|||||||
		{
 | 
							{
 | 
				
			||||||
			name:        "should error out; create failed",
 | 
								name:        "should error out; create failed",
 | 
				
			||||||
			p:           NewFailedCreatePrepuller(),
 | 
								p:           NewFailedCreatePrepuller(),
 | 
				
			||||||
			timeout:     10 * time.Second,
 | 
								timeout:     constants.PrepullImagesInParallelTimeout,
 | 
				
			||||||
			expectedErr: true,
 | 
								expectedErr: true,
 | 
				
			||||||
		},
 | 
							},
 | 
				
			||||||
		{
 | 
							{
 | 
				
			||||||
			name:        "should error out; timeout exceeded",
 | 
								name:        "should error out; timeout exceeded",
 | 
				
			||||||
			p:           NewForeverWaitPrepuller(),
 | 
								p:           NewForeverWaitPrepuller(),
 | 
				
			||||||
			timeout:     10 * time.Second,
 | 
								timeout:     constants.PrepullImagesInParallelTimeout,
 | 
				
			||||||
			expectedErr: true,
 | 
								expectedErr: true,
 | 
				
			||||||
		},
 | 
							},
 | 
				
			||||||
		{
 | 
							{
 | 
				
			||||||
			name:        "should error out; delete failed",
 | 
								name:        "should error out; delete failed",
 | 
				
			||||||
			p:           NewFailedDeletePrepuller(),
 | 
								p:           NewFailedDeletePrepuller(),
 | 
				
			||||||
			timeout:     10 * time.Second,
 | 
								timeout:     constants.PrepullImagesInParallelTimeout,
 | 
				
			||||||
			expectedErr: true,
 | 
								expectedErr: true,
 | 
				
			||||||
		},
 | 
							},
 | 
				
			||||||
		{
 | 
							{
 | 
				
			||||||
			name:        "should work just fine",
 | 
								name:        "should work just fine",
 | 
				
			||||||
			p:           NewGoodPrepuller(),
 | 
								p:           NewGoodPrepuller(),
 | 
				
			||||||
			timeout:     10 * time.Second,
 | 
								timeout:     constants.PrepullImagesInParallelTimeout,
 | 
				
			||||||
			expectedErr: false,
 | 
								expectedErr: false,
 | 
				
			||||||
		},
 | 
							},
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user